Reviewed-by: Jaben Carsey <[email protected]>
> -----Original Message----- > From: edk2-devel [mailto:[email protected]] On Behalf Of Qiu > Shumin > Sent: Monday, December 14, 2015 11:55 PM > To: [email protected] > Cc: Carsey, Jaben <[email protected]>; Qiu, Shumin > <[email protected]> > Subject: [edk2] [PATCH] ShellPkg: Fix the 'bcfg' command ASSERT when use > some invalid parameters. > Importance: High > > 'bcfg boot mv xx yy' command will ASSET when xx is larger than the count of > boot options. > This patch correct the order of ShellPrintHiiEx parameters to fix the bugs. > > Cc: Jaben Carsey <[email protected]> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Qiu Shumin <[email protected]> > --- > ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c | 4 > ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git > a/ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c > b/ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c > index eeee055..142504a 100644 > --- a/ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c > +++ > b/ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c > @@ -2,7 +2,7 @@ > Main file for BCFG command. > > (C) Copyright 2014-2015 Hewlett-Packard Development Company, L.P.<BR> > - Copyright (c) 2010 - 2014, Intel Corporation. All rights reserved.<BR> > + Copyright (c) 2010 - 2015, Intel Corporation. All rights reserved.<BR> > This program and the accompanying materials > are licensed and made available under the terms and conditions of the BSD > License > which accompanies this distribution. The full text of the license may be > found at > @@ -1379,7 +1379,7 @@ ShellCommandRunBcfg ( > Status = ShellConvertStringToUint64(CurrentParam, &Intermediate, > TRUE, FALSE); > CurrentOperation.Number1 = (UINT16)Intermediate; > if (CurrentOperation.Number1 >= Count){ > - ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN > (STR_BCFG_NUMB_RANGE), L"bcfg", gShellBcfgHiiHandle, Count); > + ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN > (STR_BCFG_NUMB_RANGE), gShellBcfgHiiHandle, L"bcfg", Count); > ShellStatus = SHELL_INVALID_PARAMETER; > } else { > CurrentParam = ShellCommandLineGetRawValue(Package, > ++ParamNumber); > -- > 1.9.5.msysgit.1 > > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
