Jiewen, Agreed. This is a mistake, and you can discard this patch.
Thanks, --Samer -----Original Message----- From: Yao, Jiewen [mailto:jiewen....@intel.com] Sent: Monday, December 14, 2015 6:58 PM To: El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com>; edk2-devel@lists.01.org Cc: El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com>; Zhang, Chao B <chao.b.zh...@intel.com> Subject: RE: [edk2] [PATCH] SecurityPkg: Add TCG physical presence definition for clear deactivate HI Samer I checked TCG official web, the latest PPI spec at http://www.trustedcomputinggroup.org/resources/tcg_physical_presence_interface_specification Version 0.52, http://www.trustedcomputinggroup.org/files/resource_files/D6850418-1A4B-B294-D0427225D4301E82/Physical%20Presence%20Interface_1-30_0-52.pdf I checked "Table 1: Physical Presence Interface Operation Summary for TPM 1.2", But I cannot to find " PHYSICAL_PRESENCE_CLEAR_DEACTIVATE_DISABLE 23" 23 - 127 Reserved Would you please share the info on where you get this definition? Thank you Yao Jiewen -----Original Message----- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Samer El-Haj-Mahmoud Sent: Tuesday, December 15, 2015 8:33 AM To: edk2-devel@lists.01.org Cc: Samer El-Haj-Mahmoud; Zhang, Chao B Subject: [edk2] [PATCH] SecurityPkg: Add TCG physical presence definition for clear deactivate Add PHYSICAL_PRESENCE_CLEAR_DEACTIVATE_DISABLE Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Samer El-Haj-Mahmoud <el...@hpe.com> --- SecurityPkg/Include/Guid/PhysicalPresenceData.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/SecurityPkg/Include/Guid/PhysicalPresenceData.h b/SecurityPkg/Include/Guid/PhysicalPresenceData.h index 165b464..2ecb446 100644 --- a/SecurityPkg/Include/Guid/PhysicalPresenceData.h +++ b/SecurityPkg/Include/Guid/PhysicalPresenceData.h @@ -5,6 +5,7 @@ is saved to variable. Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.<BR> +(C) Copyright 2015 Hewlett Packard Enterprise Development LP<BR> This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at @@ -57,6 +58,8 @@ typedef struct { #define PHYSICAL_PRESENCE_SET_NO_PPI_MAINTENANCE_TRUE 20 #define PHYSICAL_PRESENCE_ENABLE_ACTIVATE_CLEAR 21 #define PHYSICAL_PRESENCE_ENABLE_ACTIVATE_CLEAR_ENABLE_ACTIVATE 22 +#define PHYSICAL_PRESENCE_CLEAR_DEACTIVATE_DISABLE 23 + // // This variable is used to save TPM Management Flags and corresponding operations. -- 2.6.3.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel