Daocheng: PEI phase global variable can't be used. You need to locate PPI in every function call.
Thanks Liming -----Original Message----- From: edk2-devel [mailto:[email protected]] On Behalf Of Daocheng Bu Sent: Wednesday, December 16, 2015 9:46 PM To: [email protected] Cc: Yao, Jiewen Subject: [edk2] [Patch] MdeModulePkg: Add PeiIpmiLibIpmiPpi Library Class. Add PeiIpmiLibIpmiPpi Library Class that will depend on Ipmi stack PEIM produces Ipmi Ppi in Pei Phase under SMS. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daocheng Bu <[email protected]> CC: Jiewen Yao <[email protected]> --- .../Library/PeiIpmiLibIpmiPpi/PeiIpmiLibIpmiPpi.c | 76 ++++++++++++++++++++++ .../PeiIpmiLibIpmiPpi/PeiIpmiLibIpmiPpi.inf | 41 ++++++++++++ 2 files changed, 117 insertions(+) create mode 100644 MdeModulePkg/Library/PeiIpmiLibIpmiPpi/PeiIpmiLibIpmiPpi.c create mode 100644 MdeModulePkg/Library/PeiIpmiLibIpmiPpi/PeiIpmiLibIpmiPpi.inf diff --git a/MdeModulePkg/Library/PeiIpmiLibIpmiPpi/PeiIpmiLibIpmiPpi.c b/MdeModulePkg/Library/PeiIpmiLibIpmiPpi/PeiIpmiLibIpmiPpi.c new file mode 100644 index 0000000..e8baf6c --- /dev/null +++ b/MdeModulePkg/Library/PeiIpmiLibIpmiPpi/PeiIpmiLibIpmiPpi.c @@ -0,0 +1,76 @@ +/** @file + Implementation of Ipmi Library in PEI Phase for SMS. + + Copyright (c) 2014 - 2015, Intel Corporation. All rights + reserved.<BR> This program and the accompanying materials are + licensed and made available under the terms and conditions of the BSD + License which accompanies this distribution. The full text of the + license may be found at http://opensource.org/licenses/bsd-license.php. + + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. + +**/ + +#include <PiPei.h> +#include <Ppi/IpmiPpi.h> +#include <Library/IpmiLib.h> +#include <Library/PeiServicesLib.h> +#include <Library/DebugLib.h> + +STATIC PEI_IPMI_PPI *mIpmiPpi = NULL; + +/** + This service enables sumitting commands via Ipmi. + + @param[in] NetFunction Net function of the command. + @param[in] Command IPMI Command. + @param[in] CommandData Command Data. + @param[in] CommandDataSize Size of Command Data. + @param[out] ResponseData Command Response Data. + @param[in out] ResponseDataSize Size of Command Response Data. + + @retval EFI_SUCCESS The command byte stream was successfully sent to the device and a response was successfully received. + @retval EFI_NOT_FOUND The command was not successfully sent to the device or a response was not successfully received from the device. +**/ +EFI_STATUS +IpmiSubmitCommand ( + IN UINT8 NetFunction, + IN UINT8 Command, + IN UINT8 *CommandData, + IN UINT8 CommandDataSize, + OUT UINT8 *ResponseData, + IN OUT UINT8 *ResponseDataSize +{ + EFI_STATUS Status; + + if (mIpmiPpi == NULL) { + Status = PeiServicesLocatePpi( + &gPeiIpmiPpiGuid, + 0, + NULL, + (VOID **) &mIpmiPpi + ); + if (EFI_ERROR (Status)) { + // + // Ipmi Ppi is not installed. So, IPMI device is not present. + // + DEBUG ((EFI_D_ERROR, "IpmiSubmitCommand in Pei Phase under SMS Status - %r\n", Status)); + return EFI_NOT_FOUND; + } + } + + Status = mIpmiPpi->SendIpmiCommand ( + mIpmiPpi, + NetFunction, + Command, + CommandData, + CommandDataSize, + ResponseData, + ResponseDataSize + ); + if (EFI_ERROR (Status)) { + return Status; + } + return EFI_SUCCESS; +} diff --git a/MdeModulePkg/Library/PeiIpmiLibIpmiPpi/PeiIpmiLibIpmiPpi.inf b/MdeModulePkg/Library/PeiIpmiLibIpmiPpi/PeiIpmiLibIpmiPpi.inf new file mode 100644 index 0000000..7fa3ed2 --- /dev/null +++ b/MdeModulePkg/Library/PeiIpmiLibIpmiPpi/PeiIpmiLibIpmiPpi.inf @@ -0,0 +1,41 @@ +## @file +# Instance of IPMI Library in PEI phase for SMS. +# +# Copyright (c) 2014 - 2015, Intel Corporation. All rights +reserved.<BR> # # This program and the accompanying materials # are +licensed and made available under the terms and conditions of the BSD +License # which accompanies this distribution. The full text of the +license may be found at # http://opensource.org/licenses/bsd-license.php. +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" +BASIS, # WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. +# +# +## + +[Defines] + INF_VERSION = 0x00010005 + BASE_NAME = PeiIpmiLibIpmiPpi + FILE_GUID = 43679142-87C4-44AD-AF02-B47F782D6CF3 + MODULE_TYPE = PEIM + VERSION_STRING = 1.0 + LIBRARY_CLASS = IpmiLib|PEIM PEI_CORE + +# +# VALID_ARCHITECTURES = IA32 X64 +# + +[Sources] + PeiIpmiLibIpmiPpi.c + +[Packages] + MdePkg/MdePkg.dec + MdeModulePkg/MdeModulePkg.dec + +[LibraryClasses] + DebugLib + BaseMemoryLib + PeiServicesLib + +[Ppis] + gPeiIpmiPpiGuid -- 2.5.1.windows.1 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
