Mike, Yes we ran into specific devices that require this.
In general, ARM SoC's will memory map UART resources. It is important to be able to indicate to the OS the permitted size of the memory transactions when accessing these resources. The SPCR spec was not changed to indicate that it uses the latest Generic Address Structure, but it does specifically indicate that it uses the Generic Address Structure. The SPCR spec has been updated since the Generic Address Structure was updated to add AccessWidth (post 2.0), so it could be implied that the SPCR assumes the latest Generic Address Structure... Thanks, --Samer -----Original Message----- From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Tuesday, December 22, 2015 9:51 AM To: El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com>; edk2-devel@lists.01.org Cc: Gao, Liming <liming....@intel.com>; El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com> Subject: RE: [PATCH] MdePkg : Update SPCR to use ACPI5 definition Samer, Why is this change being made? I did not see an update to the SPCR spec to require the ACPI 5.0 descriptor. Is there a device that requires the AccessSize field and OSes use the AccessSize field? Thanks, Mike > -----Original Message----- > From: Samer El-Haj-Mahmoud [mailto:samer.el-haj-mahm...@hpe.com] > Sent: Monday, December 21, 2015 4:50 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Gao, Liming > <liming....@intel.com>; Samer El-Haj-Mahmoud > <samer.el-haj-mahm...@hpe.com>; Samer El-Haj-Mahmoud <el...@hpe.com> > Subject: [PATCH] MdePkg : Update SPCR to use ACPI5 definition > > Update BaseAddress in the SPCR structure to use > EFI_ACPI_5_0_GENERIC_ADDRESS_STRUCTURE > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Samer El-Haj-Mahmoud <el...@hpe.com> > --- > MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h | > 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git > a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h > b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h > index bf29505..d57518d 100644 > --- > a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h > +++ b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTabl > +++ e.h > @@ -3,6 +3,7 @@ > http://www.microsoft.com/whdc/system/platform/server/spcr.mspx > > Copyright (c) 2007 - 2015, Intel Corporation. All rights > reserved.<BR> > + (C) Copyright 2015 Hewlett Packard Enterprise Development LP<BR> > This program and the accompanying materials > are licensed and made available under the terms and conditions of the BSD > License > which accompanies this distribution. The full text of the license > may be found at @@ -35,7 +36,7 @@ typedef struct { > EFI_ACPI_DESCRIPTION_HEADER Header; > UINT8 InterfaceType; > UINT8 Reserved1[3]; > - EFI_ACPI_2_0_GENERIC_ADDRESS_STRUCTURE BaseAddress; > + EFI_ACPI_5_0_GENERIC_ADDRESS_STRUCTURE BaseAddress; > UINT8 InterruptType; > UINT8 Irq; > UINT32 GlobalSystemInterrupt; > -- > 2.6.3.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
