Reviewed-by: Chao Zhang <[email protected]>
Thanks & Best regards Chao Zhang -----Original Message----- From: El-Haj-Mahmoud, Samer [mailto:[email protected]] Sent: Thursday, December 24, 2015 11:02 PM To: Zhang, Chao B; [email protected] Cc: El-Haj-Mahmoud, Samer Subject: RE: [PATCH] SecurityPkg - Rename TisTpmCommand to avoid name collision Chao, That is already included in this patch: @@ -478,7 +478,7 @@ TisTpmCommand ( } } DEBUG_CODE ( - DEBUG ((EFI_D_VERBOSE, "TisTpmCommand ReceiveHeader - ")); + DEBUG ((EFI_D_VERBOSE, "Tpm2TisTpmCommand ReceiveHeader - ")); for (Index = 0; Index < sizeof (TPM2_RESPONSE_HEADER); Index++) { DEBUG ((EFI_D_VERBOSE, "%02x ", BufferOut[Index])); } -----Original Message----- From: Zhang, Chao B [mailto:[email protected]] Sent: Monday, December 21, 2015 8:44 PM To: El-Haj-Mahmoud, Samer <[email protected]>; [email protected] Cc: El-Haj-Mahmoud, Samer <[email protected]> Subject: RE: [PATCH] SecurityPkg - Rename TisTpmCommand to avoid name collision Samer: Please also update debug log in Line 480 DEBUG_CODE ( DEBUG ((EFI_D_VERBOSE, "TisTpmCommand ReceiveHeader - ")); for (Index = 0; Index < sizeof (TPM2_RESPONSE_HEADER); Index++) { DEBUG ((EFI_D_VERBOSE, "%02x ", BufferOut[Index])); } DEBUG ((EFI_D_VERBOSE, "\n")); ); Thanks & Best regards Chao Zhang -----Original Message----- From: Samer El-Haj-Mahmoud [mailto:[email protected]] Sent: Tuesday, December 22, 2015 8:10 AM To: [email protected] Cc: Zhang, Chao B; Samer El-Haj-Mahmoud; Samer El-Haj-Mahmoud Subject: [PATCH] SecurityPkg - Rename TisTpmCommand to avoid name collision Rename TisTpmCommand to Tpm2TisTpmCommand to naming collision with similar function name in other libraries. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Samer El-Haj-Mahmoud <[email protected]> --- SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Tis.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Tis.c b/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Tis.c index b7dd57d..1276aea 100644 --- a/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Tis.c +++ b/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Tis.c @@ -370,7 +370,7 @@ TisPcRequestUseTpm ( **/ EFI_STATUS -TisTpmCommand ( +Tpm2TisTpmCommand ( IN TIS_PC_REGISTERS_PTR TisReg, IN UINT8 *BufferIn, IN UINT32 SizeIn, @@ -478,7 +478,7 @@ TisTpmCommand ( } } DEBUG_CODE ( - DEBUG ((EFI_D_VERBOSE, "TisTpmCommand ReceiveHeader - ")); + DEBUG ((EFI_D_VERBOSE, "Tpm2TisTpmCommand ReceiveHeader - ")); for (Index = 0; Index < sizeof (TPM2_RESPONSE_HEADER); Index++) { DEBUG ((EFI_D_VERBOSE, "%02x ", BufferOut[Index])); } @@ -553,7 +553,7 @@ DTpm2SubmitCommand ( IN UINT8 *OutputParameterBlock ) { - return TisTpmCommand ( + return Tpm2TisTpmCommand ( (TIS_PC_REGISTERS_PTR) (UINTN) PcdGet64 (PcdTpmBaseAddress), InputParameterBlock, InputParameterBlockSize, -- 2.6.3.windows.1 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
