Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -----Original Message----- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of El- > Haj-Mahmoud, Samer > Sent: Tuesday, January 05, 2016 10:55 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com>; Qiu, Shumin > <shumin....@intel.com> > Subject: Re: [edk2] [PATCH v2] ShellPkg : Add UEFI_APPLICATION module > type to UefiShellInstall1CommandsLib.inf > Importance: High > > Jaben, > > Can you please review? > > Thanks, > --Samer > > > -----Original Message----- > From: El-Haj-Mahmoud, Samer > Sent: Thursday, December 24, 2015 9:10 AM > To: edk2-devel@lists.01.org > Cc: Jaben Carsey <jaben.car...@intel.com>; Shumin Qiu > <shumin....@intel.com>; El-Haj-Mahmoud, Samer <samer.el-haj- > mahm...@hpe.com>; El-Haj-Mahmoud, Samer <samer.el-haj- > mahm...@hpe.com> > Subject: [PATCH v2] ShellPkg : Add UEFI_APPLICATION module type to > UefiShellInstall1CommandsLib.inf > > Using UEFI_APPLICATION for all Shell app and libraries allows the use of > different compiler flags for the Shell application itself and for other > applications that are built separately that use Shell libraries. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Samer El-Haj-Mahmoud <el...@hpe.com> > --- > .../UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf | 3 > ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git > a/ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsL > ib.inf > b/ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1Commands > Lib.inf > index dc1b622..7ea306d 100644 > --- > a/ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsL > ib.inf > +++ b/ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1Com > +++ mandsLib.inf > @@ -2,6 +2,7 @@ > # Provides shell install1 functions > # > # Copyright (c) 2010 - 2015, Intel Corporation. All rights reserved. <BR> > +# (C) Copyright 2015 Hewlett Packard Enterprise Development LP<BR> > # > # This program and the accompanying materials # are licensed and made > available under the terms and conditions of the BSD License @@ -16,7 +17,7 > @@ > INF_VERSION = 0x00010006 > BASE_NAME = UefiShellInstall1CommandsLib > FILE_GUID = D250E364-51C6-49ed-AEBF-6D83F5130F74 > - MODULE_TYPE = UEFI_DRIVER > + MODULE_TYPE = UEFI_DRIVER UEFI_APPLICATION > VERSION_STRING = 1.0 > LIBRARY_CLASS = NULL|UEFI_APPLICATION UEFI_DRIVER > CONSTRUCTOR = ShellInstall1CommandsLibConstructor > -- > 2.6.3.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
