Hi Laszlo, The patch is good to me. Reviewed-by: Jiaxin Wu <[email protected]>
Do you need my help to commit this one or by yourself? Thanks. Jiaxin -----Original Message----- From: Laszlo Ersek [mailto:[email protected]] Sent: Wednesday, January 6, 2016 4:30 AM To: [email protected] Cc: Subramanian Sriram; El-Haj-Mahmoud Samer; Ye, Ting; Fu, Siyuan; Wu, Jiaxin Subject: [PATCH] NetworkPkg: DnsDxe: fix return type of DnsFillinQNameForQueryIp() Change the return type of DnsFillinQNameForQueryIp() from (UINT8*) to (CHAR*). This brings the function in sync with both its internal variables and all of its call sites, fixing the following gcc build breakage: > NetworkPkg/DnsDxe/DnsImpl.c: In function 'DnsFillinQNameForQueryIp': > NetworkPkg/DnsDxe/DnsImpl.c:1068:3: error: pointer targets in return > differ in signedness > [-Werror=pointer-sign] > return QueryName; > ^ The code was added in git commit fcae1a99 (SVN r19579). Cc: Subramanian Sriram <[email protected]> Cc: El-Haj-Mahmoud Samer <[email protected]> Cc: Ye Ting <[email protected]> Cc: Fu Siyuan <[email protected]> Cc: Jiaxin Wu <[email protected]> Cc: Ye Ting <[email protected]> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek <[email protected]> --- NetworkPkg/DnsDxe/DnsImpl.h | 2 +- NetworkPkg/DnsDxe/DnsImpl.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/NetworkPkg/DnsDxe/DnsImpl.h b/NetworkPkg/DnsDxe/DnsImpl.h index a13355f..847cd15 100644 --- a/NetworkPkg/DnsDxe/DnsImpl.h +++ b/NetworkPkg/DnsDxe/DnsImpl.h @@ -581,7 +581,7 @@ AddDns6ServerIp ( @return QName filled successfully. **/ -UINT8 * +CHAR8 * EFIAPI DnsFillinQNameForQueryIp ( IN CHAR16 *HostName diff --git a/NetworkPkg/DnsDxe/DnsImpl.c b/NetworkPkg/DnsDxe/DnsImpl.c index 8725670..362af86 100644 --- a/NetworkPkg/DnsDxe/DnsImpl.c +++ b/NetworkPkg/DnsDxe/DnsImpl.c @@ -1026,7 +1026,7 @@ AddDns6ServerIp ( @return QName filled successfully. **/ -UINT8 * +CHAR8 * EFIAPI DnsFillinQNameForQueryIp ( IN CHAR16 *HostName -- 1.8.3.1 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
