Hi Star,
On Fri, Jan 15, 2016 at 06:03:10PM +0800, Zeng, Star wrote:
> >>> git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18378
> >>>6f19259b-4bc3-4df7-8a09-765794883524
> >>>
> >>>This is because Intel BDS using cursor keys, ARM BDS does not.
> >>
> >>
> >>Sorry, I am not familiar with ARM platform and can only analyze the problem
> >>by code review. Up to now, I have no idea about the reason since the code
> >>implementation are same but just in different library instances.
> >>
> >>Could you push your code into your fork? Then we can get it to have a look.
> >>
> >
> >Sure, I've just pushed it:
> >
> >https://git.linaro.org/landing-teams/working/arm/edk2.git/shortlog/refs/heads/serialdxe-fix-005
> >
> >It's in the "serialdxe-fix-005" branch.
>
> I checked out the code and had a look. I found there is no one to link the
> added back PL011SerialPortExtLib, and I do not understand why the added back
> PL011SerialPortExtLib will cause PL011SerialPortLib to have compile failure
> you said in previous email and commit log.
>
> Could you check out to *SHA-1: 1b96428d92c01383dc437717db679f57cf70d980*
> that just before my SerialDxe series changes, and help to confirm if there
> is regression?
I can confirm this regression, and I can also confirm I tested your
refactoring without spotting the issue, since serial _output_ still
works :|
/
Leif
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
