On 15 January 2016 at 17:07, Ryan Harkin <[email protected]> wrote: > On 15 January 2016 at 15:42, Ard Biesheuvel <[email protected]> wrote: >> SerialDxe was migrated to MdeModulePkg from EmbeddedPkg, and all >> users of the latter were moved to the former. However, the new >> version is not quite identical to the original, in ways that break >> ARM platforms that use the PL011 driver. >> > > The original patch should never have passed review. >
My apologies. I did review the patch, but did not notice that the patch not only moved code around, but also made modifications at the same time. @Star: *please*, the next time you want to move code *and* make changes to it, split it up in separate patches so reviewers don't have to read through hundreds of lines of code. Thanks, Ard. > >> In SerialReset(), the serial port is reset to its default values, >> but the defaults used by the new version for ReceiveFifoDepth and >> Timeout deviate from the original values. So put them back. >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Ard Biesheuvel <[email protected]> > Tested-by: Ryan Harkin <[email protected]> > >> --- >> MdeModulePkg/Universal/SerialDxe/SerialIo.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/MdeModulePkg/Universal/SerialDxe/SerialIo.c >> b/MdeModulePkg/Universal/SerialDxe/SerialIo.c >> index de928d1719e9..9e9db28ce5cc 100644 >> --- a/MdeModulePkg/Universal/SerialDxe/SerialIo.c >> +++ b/MdeModulePkg/Universal/SerialDxe/SerialIo.c >> @@ -233,8 +233,8 @@ SerialReset ( >> // >> // Set the Serial I/O mode >> // >> - This->Mode->ReceiveFifoDepth = 1; >> - This->Mode->Timeout = 0; >> + This->Mode->ReceiveFifoDepth = 0; >> + This->Mode->Timeout = 1000000; >> This->Mode->BaudRate = PcdGet64 (PcdUartDefaultBaudRate); >> This->Mode->DataBits = (UINT32) PcdGet8 (PcdUartDefaultDataBits); >> This->Mode->Parity = (UINT32) PcdGet8 (PcdUartDefaultParity); >> -- >> 2.5.0 >> _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
