Laszlo & John

Thanks for your detail analysis. It's very helpful for me.

Reviewed-by: Feng Tian <feng.t...@intel.com>

I am thinking shall we update EFI_SCSI_INQUIRY_DATA/ATAPI_INQUIRY_DATA data 
structure as well to only contain the first 36 bytes?  According to ATAPI SFF 
8020i & SPC4 spec, they all state the inquiry data includes at least 36 bytes. 
But we defines it as 96 bytes or more.

Thanks
Feng

-----Original Message-----
From: Laszlo Ersek [mailto:ler...@redhat.com] 
Sent: Tuesday, January 19, 2016 08:35
To: edk2-de...@ml01.01.org
Cc: Tian, Feng; Zeng, Star; John Snow
Subject: [PATCH 0/2] MdeModulePkg/.../IdeMode: restore handling of "short reads"

The series

  [edk2] [patch 0/2] Fix a DVD device compatbility issue
  http://thread.gmane.org/gmane.comp.bios.edk2.devel/3681

fixed an IDE timeout masking (misreporting) bug in the AtaAtapiPassThru driver. 
(And, separately, it increased SCSI disk timeouts to 30s.) However, the IDE 
change that improved the reporting of timeouts regressed the handling of short 
reads.

Users reported this in <https://github.com/tianocore/edk2/issues/43>,
running the code in question as part of OVMF, on QEMU's i440fx IDE emulation. 
These patches aim to fix the short reads.

Cc: Feng Tian <feng.t...@intel.com>
Cc: Star Zeng <star.z...@intel.com>
Cc: John Snow <js...@redhat.com>

Thanks
Laszlo

Laszlo Ersek (2):
  MdeModulePkg/.../IdeMode: actualize DRQReady*() comment blocks
  MdeModulePkg/.../IdeMode: report early finish of packet read as
    success

 MdeModulePkg/Bus/Ata/AtaAtapiPassThru/IdeMode.c | 37 ++++++++++++++++----
 1 file changed, 31 insertions(+), 6 deletions(-)

--
1.8.3.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to