All 3 modified libraries need their version information modified. I think that the minor version of all 3 libraries debug, BCFG, and ShellCommandLib need to be incremented.
Otherwise I think this looks good. -Jaben > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Wednesday, January 20, 2016 5:12 PM > To: edk2-de...@ml01.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com>; Ryan Harkin > <ryan.har...@linaro.org> > Subject: [edk2] [PATCH 00/13] ShellPkg: BCFG dump improvements > Importance: High > > This series cleans up the "bcfg dump" command, fixes two bugs in it, and > improves the hexdump of the optional data. > > Public branch: > <https://github.com/lersek/edk2/commits/bcfg_improvements>. > > Don't be alarmed by the seemingly large number of patches, I advanced in > microscopic steps. > > Cc: Jaben Carsey <jaben.car...@intel.com> > Cc: Ryan Harkin <ryan.har...@linaro.org> > > Thanks > Laszlo > > Laszlo Ersek (13): > ShellPkg: UefiShellBcfgCommandLib: update whitespace & layout > ShellPkg: UefiShellBcfgCommandLib: drop unused string tokens > ShellPkg: UefiShellBcfgCommandLib: hoist NULL-init of DevPath[String] > ShellPkg: UefiShellBcfgCommandLib: accumulate errors > ShellPkg: UefiShellBcfgCommandLib: enforce minimum size for Boot#### > and co. > ShellPkg: UefiShellBcfgCommandLib: address FilePathListLength by name > ShellPkg: UefiShellBcfgCommandLib: call Description[Size] by name > ShellPkg: UefiShellBcfgCommandLib: eliminate FilePathList duplication > ShellPkg: UefiShellBcfgCommandLib: calculate OptionalDataOffset > explicitly > ShellPkg: UefiShellBcfgCommandLib: fix reporting of OptionalData > ShellPkg: UefiShellBcfgCommandLib: fix ShellPrintEx() call site > ShellPkg: elevate DumpHex() from Debug1-internal to generic-internal > ShellPkg: UefiShellBcfgCommandLib: print optional data with DumpHex() > > ShellPkg/Include/Library/ShellCommandLib.h | > 16 +++ > > ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib. > h | 16 --- > ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c | > 103 ++++++++++++-------- > ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c | > 69 > +++++++++++++ > > ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib. > c | 70 ------------- > ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.uni | > 4 +- > 6 files changed, 147 insertions(+), 131 deletions(-) > > -- > 1.8.3.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
