HI Star, I tried to remove SmbusLib.h from InternalS3SaveState.h., there will be build errors.Smbus related logic exists in S3SaveState.c
At 2016-01-21 18:09:41, "Zeng, Star" <star.z...@intel.com> wrote: >It is just to include header file, I believe it could be removed from >InternalS3SaveState.h. >What libraries a driver will link is not determined by source files, but inf >file ( S3SaveStateDxe.inf)? > >Why does S3SaveStateDxe.inf finally link SmbusLib, it is because >S3SaveStateDxe.inf link S3BootScriptLib(I guess you are using >DxeS3BootScriptLib.inf in MdeModulePkg) and S3BootScriptLib link SmbusLib. > >You may could check the PCD usage in your SmbusLib instance. > >Thanks, >Star >From: 王晓峰 [mailto:winggundu...@163.com] >Sent: Thursday, January 21, 2016 5:40 PM >To: edk2-de...@ml01.01.org >Cc: Zeng, Star >Subject: [edk2] S3SaveStateDxe.inf doesn't explicitly include SmbusLib, is it >a bug? > >Hi All, > I meet a issue that there is a get PCD assert for S3SaveStateDxe.inf. It > is strange that I seached all the library and their child library in > S3SaveStateDxe.inf , no PCD found related to this issue > >[LibraryClasses] > UefiBootServicesTableLib > MemoryAllocationLib > UefiDriverEntryPoint > BaseMemoryLib > BaseLib > S3BootScriptLib > > Then I found in InternalS3SaveState.h, It directly include SmbusLib > #include <Library/SmbusLib.h> > > I am not sure whether it is a bug that SmbusLib should also be in > S3SaveStateDxe.inf . But after I change SmbusLib instance to Null the PCD > issue is solved. It seems build tool for PCD cannot caclulate the PCD > introduced by such way. > > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
