I am OK with the fix. Reviewed-by: Feng Tian <feng.t...@intel.com>
PS: The "should" words is my thought on the write case (not tested as well:-)). I thought the first patch should also work on short write case. Thanks Feng -----Original Message----- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Saturday, January 23, 2016 00:59 To: Paolo Bonzini; Tian, Feng Cc: edk2-de...@ml01.01.org; js...@redhat.com Subject: Re: [edk2] [PATCH] MdeModulePkg/.../IdeMode: correctly report length of returned data On 01/22/16 15:23, Paolo Bonzini wrote: > > > On 21/01/2016 02:27, Tian, Feng wrote: >> Paolo, >> >> I think for short write case it means the data length to be written >> in AtaPacketReadWrite, that is ByteCount, is less than the one >> shipped in ATA cmd, for example, CDB (READ10.byte7&8). >> >> For such case, it should jump out the while loop in >> AtaPacketReadWrite and send EFI_DEVICE_ERROR as DRQ is not clear. >> >> IMHO, Laszo & your patch all looks ok to me. of course, your patch >> did an enhancement on how to reflect the real transfer data length >> :) > > Thanks! Laszlo, can you commit it? Absolutely; I haven't done it already only because Feng didn't send a formal R-b. That fact, combined with "it should ..." in the second paragraph, told me that there were further details to iron out. If that's not the case: Feng, can you please post your Reviewed-by as usual? Then I'll add my own T-b as well (already posted) and commit Paolo's patch. Thanks Laszlo _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
