Reviewed-by: Jiaxin Wu <[email protected]>
-----Original Message----- From: Fu, Siyuan Sent: Friday, February 5, 2016 10:21 AM To: [email protected] Cc: Ye, Ting <[email protected]>; Subramanian Sriram <[email protected]>; Wu, Jiaxin <[email protected]> Subject: [Patch 1/2] MdeModulePkg: Make the DEBUG info consistent in SNP driver. SNP driver will print the UNDI returned StatFlags:StatCode with DEBUG macro, while in some please it uses the reverse order (StatCode:StatFlags). This patch is to make the print info consistent, that StatFlags always come first. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Fu Siyuan <[email protected]> CC: Ye Ting <[email protected]> CC: Subramanian Sriram <[email protected]> CC: Wu Jiaxin <[email protected]> --- MdeModulePkg/Universal/Network/SnpDxe/Get_status.c | 2 +- MdeModulePkg/Universal/Network/SnpDxe/Stop.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/MdeModulePkg/Universal/Network/SnpDxe/Get_status.c b/MdeModulePkg/Universal/Network/SnpDxe/Get_status.c index fad2e98..4da07b5 100644 --- a/MdeModulePkg/Universal/Network/SnpDxe/Get_status.c +++ b/MdeModulePkg/Universal/Network/SnpDxe/Get_status.c @@ -85,7 +85,7 @@ PxeGetStatus ( (EFI_D_NET, "\nSnp->undi.get_status() %xh:%xh\n", Snp->Cdb.StatFlags, - Snp->Cdb.StatFlags) + Snp->Cdb.StatCode) ); return EFI_DEVICE_ERROR; diff --git a/MdeModulePkg/Universal/Network/SnpDxe/Stop.c b/MdeModulePkg/Universal/Network/SnpDxe/Stop.c index 730e397..a52d3b1 100644 --- a/MdeModulePkg/Universal/Network/SnpDxe/Stop.c +++ b/MdeModulePkg/Universal/Network/SnpDxe/Stop.c @@ -1,7 +1,7 @@ /** @file Implementation of stopping a network interface. -Copyright (c) 2004 - 2007, Intel Corporation. All rights reserved.<BR> +Copyright (c) 2004 - 2016, Intel Corporation. All rights reserved.<BR> This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at @@ -51,8 +51,8 @@ PxeStop ( DEBUG ( (EFI_D_WARN, "\nsnp->undi.stop() %xh:%xh\n", - Snp->Cdb.StatCode, - Snp->Cdb.StatFlags) + Snp->Cdb.StatFlags, + Snp->Cdb.StatCode) ); return EFI_DEVICE_ERROR; -- 2.7.0.windows.2 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
