Hi Jeremy, I just wanted to follow up on this old patch series. I've pushed them into my tree for the 16.02 Platforms release [1].
However, Leif had a few comments, as do I, and it would be good to get them addressed so we can get the code upstream. First thing I noticed was that patch 3 wouldn't apply. Git was convinced it was corrupt no matter what I did, so I applied it by hand. While I was applying it, I dropped gArmGlobalVariableGuid from SmbiosPlatformDxe.inf. It was unused and Ard removed it from the code base shortly after you posted your series, I think. Keep that in mind why you update them. For what it's worth, with your patches in place, I now see a lovely title banner in Intel BDS: ARM Juno Development Platform Cortex-A57 0.65 GHz EDK II 0 MB RAM Unfortunately, the data isn't correct. I think the A57 is running at 800 MHz and the A53 is at 650 MHz on R1. But the board boots from A53, so I assume it's supposed to say "Cortex-A53" on the UI. Then, when I run it on R2, it still says it's an A57 at 0.65 GHz / 650 Mhz, when the board has A72s running at 1 Ghz and A53s at 800 Mhz. I assume the 650 is coming from "mArmDefaultType4_a53", so I guess there needs to be something smarter in there. And the amount of RAM should be fixed up too. Cheers, Ryan. [1] https://git.linaro.org/landing-teams/working/arm/edk2.git/shortlog/refs/tags/armlt-20160205 On 20 November 2015 at 22:18, Jeremy Linton <[email protected]> wrote: > SMBIOS data is consumed by a wide range of enterprise applications. > > This patch adds basic SMBIOS data for the ARM Juno. Most of the > data is static. The system memory layout and juno revision > are updated depending on the platform. To accomplish the juno revision > detection the Juno revision code in ArmJunoDxe was hoisted into the > platform.h file on the recommendation of others (to avoid a AFTER > dependency). > > With this patch, both the EFI shell and linux dmidecode commands > return useful information. > > Jeremy Linton (3): > Code to detect what juno revision we are running on. > Convert ArmJunoDxe to use common juno revision code > ArmPlatformPkg/ArmJunoPkg: Create SMBIOS/DMI data for Juno > > ArmPlatformPkg/ArmJunoPkg/ArmJuno.dsc | 12 + > ArmPlatformPkg/ArmJunoPkg/ArmJuno.fdf | 6 + > .../ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c | 52 +- > ArmPlatformPkg/ArmJunoPkg/Include/ArmPlatform.h | 41 ++ > .../SmbiosPlatformDxe/SmbiosPlatformDxe.c | 781 > +++++++++++++++++++++ > .../SmbiosPlatformDxe/SmbiosPlatformDxe.inf | 69 ++ > 6 files changed, 917 insertions(+), 44 deletions(-) > create mode 100644 > ArmPlatformPkg/ArmJunoPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c > create mode 100644 > ArmPlatformPkg/ArmJunoPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.inf > > -- > 2.4.3 > > _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
