On 02/09/16 12:41, Ryan Harkin wrote: > This patch makes a few minor DEBUG output changes: > > - Fix typo in DEBUG output: Negociation->Negotiation > > - Change DEBUG occurrences of "Lan9118" to "LAN9118" to make grepping > the log output easier. > > - Change the warning that auto-negotiation is not supported when > AutoNegotiate() returns an error. > The function already reports if the feature is supported or not and > can also return an error for other reasons. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ryan Harkin <[email protected]> > --- > EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.c > b/EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.c > index 79bee3f..d0bf7be 100644 > --- a/EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.c > +++ b/EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.c > @@ -142,7 +142,7 @@ Lan9118DxeEntry ( > // Power up the device so we can find the MAC address > Status = Lan9118Initialize (Snp); > if (EFI_ERROR (Status)) { > - DEBUG ((EFI_D_ERROR, "Lan9118: Error initialising hardware\n")); > + DEBUG ((EFI_D_ERROR, "LAN9118: Error initialising hardware\n")); > return EFI_DEVICE_ERROR; > } > > @@ -342,7 +342,7 @@ SnpInitialize ( > // Do auto-negotiation if supported > Status = AutoNegotiate (AUTO_NEGOTIATE_ADVERTISE_ALL, Snp); > if (EFI_ERROR(Status)) { > - DEBUG ((EFI_D_WARN, "Lan9118: Auto Negociation not supported.\n")); > + DEBUG ((EFI_D_WARN, "LAN9118: Auto Negotiation failed.\n")); > } > > // Configure flow control depending on speed capabilities > @@ -767,7 +767,7 @@ SnpStationAddress ( > New = (EFI_MAC_ADDRESS *) PermAddr; > Lan9118SetMacAddress ((EFI_MAC_ADDRESS *) PermAddr, Snp); > } else { > - DEBUG ((EFI_D_ERROR, "Lan9118: Warning: No valid MAC address in > EEPROM, using fallback\n")); > + DEBUG ((EFI_D_ERROR, "LAN9118: Warning: No valid MAC address in > EEPROM, using fallback\n")); > New = (EFI_MAC_ADDRESS*) (FixedPcdGet64 (PcdLan9118DefaultMacAddress)); > } > } else { >
Reviewed-by: Laszlo Ersek <[email protected]> _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
