On 02/09/16 17:53, Leif Lindholm wrote: > Thanks! > > (Argh, forgot to add your reviewed-by before I pushed!) > > So, could I do something like splitting ShellPkg/ShellBinPkg and then: > > ShellBinPkg > W: https://github.com/tianocore/tianocore.github.io/wiki/ShellPkg > M: Jaben Carsey <[email protected]> > M: Shumin Qiu <[email protected]> > M: Leif Lindholm <[email protected]> (ARM/AArch64) > M: Ard Biesheuvel <[email protected]> (ARM/AArch64)
Something like this would be especially important for MdeModulePkg maintenance, which is absolutely huge. Based on QEMU customs though, I think pathnames (directories, and filenames with wildcards) would be more appropriate: F: ShellBinPkg/UefiShell/AArch64 F: ShellBinPkg/UefiShell/Arm Thanks Laszlo > > (but getting the alignment right when I have a fixed-width font) > > / > Leif > > On 9 February 2016 at 16:42, Carsey, Jaben <[email protected]> wrote: >> Reviewed-by: Jaben Carsey <[email protected]> >> >> And yes I agree that you both should be added as maintainers of the >> ShellBinPkg. >> >>> -----Original Message----- >>> From: edk2-devel [mailto:[email protected]] On Behalf Of Leif >>> Lindholm >>> Sent: Tuesday, February 09, 2016 8:41 AM >>> To: [email protected] >>> Cc: Carsey, Jaben <[email protected]>; Qiu, Shumin >>> <[email protected]>; Laszlo Ersek <[email protected]>; Ard Biesheuvel >>> <[email protected]> >>> Subject: [edk2] [PATCH] ShellBinPkg: Arm/AArch64 Shell binary update. >>> Importance: High >>> >>> The binaries of ShellBinPkg are generated with ShellPkg from >>> 9a8f6fb40712 ("ArmPlatformPkg: remove unused Sec library"). >>> >>> This reintroduces the non-standard tftp commands that were >>> unintentionally dropped with svn r18243. >>> >>> Contributed-under: TianoCore Contribution Agreement 1.0 >>> Signed-off-by: Leif Lindholm <[email protected]> >>> --- >>> >>> Binary diff not included in email, can be found at: >>> https://git.linaro.org/people/leif.lindholm/edk2.git/shortlog/refs/heads/shellb >>> inupdate >>> >>> As a side note - could we add myself and Ard as maintainers on >>> ShellBinPkg, specifically for ARM/AArch64? >>> >>> ShellBinPkg/MinUefiShell/AArch64/Shell.efi | Bin 382304 -> 392416 bytes >>> ShellBinPkg/MinUefiShell/Arm/Shell.efi | Bin 330336 -> 338592 bytes >>> ShellBinPkg/UefiShell/AArch64/Shell.efi | Bin 873664 -> 893696 bytes >>> ShellBinPkg/UefiShell/Arm/Shell.efi | Bin 769088 -> 786592 bytes >>> 4 files changed, 0 insertions(+), 0 deletions(-) >>> >>> diff --git a/ShellBinPkg/MinUefiShell/AArch64/Shell.efi >>> b/ShellBinPkg/MinUefiShell/AArch64/Shell.efi >>> index 9faeaff..53724a6 100755 >>> Binary files a/ShellBinPkg/MinUefiShell/AArch64/Shell.efi and >>> b/ShellBinPkg/MinUefiShell/AArch64/Shell.efi differ >>> diff --git a/ShellBinPkg/MinUefiShell/Arm/Shell.efi >>> b/ShellBinPkg/MinUefiShell/Arm/Shell.efi >>> index 695f72a..251e0ca 100755 >>> Binary files a/ShellBinPkg/MinUefiShell/Arm/Shell.efi and >>> b/ShellBinPkg/MinUefiShell/Arm/Shell.efi differ >>> diff --git a/ShellBinPkg/UefiShell/AArch64/Shell.efi >>> b/ShellBinPkg/UefiShell/AArch64/Shell.efi >>> index 76b0a03..fdfd518 100755 >>> Binary files a/ShellBinPkg/UefiShell/AArch64/Shell.efi and >>> b/ShellBinPkg/UefiShell/AArch64/Shell.efi differ >>> diff --git a/ShellBinPkg/UefiShell/Arm/Shell.efi >>> b/ShellBinPkg/UefiShell/Arm/Shell.efi >>> index 4d95e08..f7a8cca 100755 >>> Binary files a/ShellBinPkg/UefiShell/Arm/Shell.efi and >>> b/ShellBinPkg/UefiShell/Arm/Shell.efi differ >>> -- >>> 2.1.4 >>> >>> _______________________________________________ >>> edk2-devel mailing list >>> [email protected] >>> https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
