Ping. This disappeared down a black hole. On 19 August 2015 at 08:56, Haojian Zhuang <[email protected]> wrote: > Changelog: > v4: > * Use 64-bit value on PL061 register base address. > * Use fallback to be compatible with current PcdPL061GpioBase value > when platform gpio driver isn't present. > * Remove the dependancy on PL061. Move the dependancy to platform > gpio driver instead. > v3: > * Remove GPIO_PIN_MASK_HIGH_8BIT() and GPIO_PIN_MASK_LOW_8BIT(). > * Avoid to use MmioAnd8() on updating GPIO DATA register, since PL061 > could access each bit by specified register offset. > * Add PLATFORM_GPIO_CONTROLLER structure in embedded gpio. > * Support multiple PL061 gpio controllers in one platform. > v2: > * Append the patch to fix gpio pin mask macro. > > Haojian Zhuang (3): > ArmPlatformPkg: PL061: fix accessing GPIO DATA > EmbeddedPkg: enhance for multiple gpio controllers > ArmPlatformPkg: PL061: support multiple controller > > ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c | 137 > +++++++++++++++------ > .../Drivers/PL061GpioDxe/PL061GpioDxe.inf | 1 + > ArmPlatformPkg/Include/Drivers/PL061Gpio.h | 51 ++++---- > EmbeddedPkg/EmbeddedPkg.dec | 1 + > EmbeddedPkg/Include/Protocol/EmbeddedGpio.h | 17 +++ > 5 files changed, 143 insertions(+), 64 deletions(-) > > -- > 2.1.4 >
I found this patch series sitting in my "review" folder. I have some really minor comments, but I'll reply to the individual patches. In the meantime, I tested this on Juno which also has PL061 and it works fine. So for the whole series: Tested-by: Ryan Harkin <[email protected]> _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
