On 02/10/16 22:15, Andrew Fish wrote: > >> On Feb 10, 2016, at 12:55 PM, Laszlo Ersek <[email protected]> wrote: >> >> On 02/10/16 20:08, Felix Poludov wrote: >>> Most of the EDKII tools support --version switch that returns tool version >>> and build number. >>> We've been using SVN revision ID as a build number for all the tools. >>> Have there been any discussions >> >> Not to my knowledge. >> >>> on what should be used as a build number in the new (and hopefully merrier) >>> EDKII Git world? >> >> IMO, clearly the git commit hash of the current tree (possibly truncated >> to 12 nibbles). >> > > I thought the --short output was shorter than that?
In my experience, git likes to work with 7 or 8 nibbles as a starting point (IIRC 7 in "git rebase -i", 8 in "git blame"), and automatically using longer hash prefixes if the 7 or 8 wouldn't be unique. (Again, I don't have documentation or hard evidence about this, just what I seem to recall.) The Linux kernel recommends 12 nibbles for future proofing references in commit messages and elsewhere. What suffices for Linux should suffice for everything else (TM). (Well, maybe not for Facebook, but they use Mercurial anyway.) https://www.kernel.org/doc/Documentation/SubmittingPatches Hm, this actually prompted me now to set core.abbrev = 12. :) I also stumbled upon <https://blog.cuviper.com/2013/11/10/how-short-can-git-abbreviate/>. [snip] Thanks Laszlo _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
