On 02/12/16 19:50, Paolo Bonzini wrote: > > > On 12/02/2016 02:09, Laszlo Ersek wrote: >> (23) Now we'll format the patches as email messages, and send them to >> the list. Standing in the root of your edk2 directory, run the >> following (note that the "-O" option needs customization: please >> update the pathname to the file created in step (10)): >> >> rm -f -- *.patch >> >> git format-patch \ >> --notes \ >> -O"/fully/qualified/path/to/edk2.diff.order" \ >> --cover-letter \ >> --numbered \ >> --subject-prefix="PATCH v1" \ >> --stat=1000 \ >> --stat-graph-width=20 \ >> master..implement_foo_for_bar_v1 > > You can add > > git config diff.orderFile "/fully/qualified/path/to/edk2.diff.order" > > to step (10) instead of adding -O.
I didn't know about "diff.orderFile", despite -O... always annoying me. Which tells me something is wrong, because I have pretty low tolerance for stuff in git annoying me, so I think I must have researched a permanent setting for -O... at some point, and failed. Let me check again. ... Indeed, "diff.orderFile" was added to git between v1.8.5 and v1.9.0. I'm on RHEL-7, and RHEL-7 ships (in RHEL-7.2.z, at the moment) git-1.8.3.1-6.el7. > Also you can add > > git config --global alias.format-series "format-patch --notes > --cover-letter --numbered --stat=1000 --stat-graph-width=20" > > to step (05) and simplify the above to > > git format-series --subject-prefix="PATCH v1" master.. Oh I definitely use a bunch of aliases, and indeed "format-series" is one of them. However, in this guide I deliberately avoided using aliases -- I intended to show the direct commands, and allow users to pack them into scripts or aliases. Also, "--stat=1000 --stat-graph-width=20" is very specific to edk2 (due to the incredibly long directory and file names it uses -- otherwise the diffstats would truncate a bunch of pathnames on the left with ...), so I think these options are not the best for --global. > >> >> git send-email \ >> --suppress-cc=author \ >> --suppress-cc=self \ >> --suppress-cc=cc \ >> --suppress-cc=sob \ >> [email protected] \ >> *.patch > > Same here. You can add more "git config" commands to step (05), > particularly > > git config send-email.to = [email protected] That's right. > > and simplify this to > > git send-email *.patch > > (Not sure why you're adding the Why the "--suppress-cc"). I like when my upstream posts go only to the To: address, and to explicit commit message Cc:'s. Thanks! Laszlo _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
