Hi Supreeth, On Wed, Feb 10, 2016 at 02:29:42PM -0600, Supreeth Venkatesh wrote: > Add ACPI6.0 macros for GIC Distributor Initialization, GICC Structure > Initialization and GIC Redistributor Initialization.
So, I have no objection to the below, but there is no public platform making use of it, so no way to test it using public code. I would prefer to not push it until that changes. Would it be much effort to update Juno to all ACPI 6? > Contributed-under: TianoCore Contribution Agreement 1.0 > Reported-by: Dennis Chen <[email protected]> > Signed-off-by: Supreeth Venkatesh <[email protected]> > Tested-by: Supreeth Venkatesh <[email protected]> No need to add the Tested-by on your own patches. That is implied unless explicitly stated otherwise. > --- > EmbeddedPkg/Include/Library/AcpiLib.h | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/EmbeddedPkg/Include/Library/AcpiLib.h > b/EmbeddedPkg/Include/Library/AcpiLib.h > index 42710fd..e88e57f 100644 > --- a/EmbeddedPkg/Include/Library/AcpiLib.h > +++ b/EmbeddedPkg/Include/Library/AcpiLib.h > @@ -38,6 +38,12 @@ > GicDistHwId, GicDistBase, GicDistVector, EFI_ACPI_RESERVED_DWORD \ > } > > +#define EFI_ACPI_6_0_GIC_DISTRIBUTOR_INIT(GicDistHwId, GicDistBase, > GicDistVector, GicVersion) \ > + { \ > + EFI_ACPI_6_0_GICD, sizeof (EFI_ACPI_6_0_GIC_DISTRIBUTOR_STRUCTURE), > EFI_ACPI_RESERVED_WORD, \ > + GicDistHwId, GicDistBase, GicDistVector, GicVersion \ > + } > + > // Note the parking protocol is configured by UEFI if required > #define EFI_ACPI_5_0_GIC_STRUCTURE_INIT(GicId, AcpiCpuId, Flags, PmuIrq, > GicBase) \ > { \ > @@ -54,12 +60,26 @@ > GsivId, GicRBase, Mpidr > \ > } > > +// Note the parking protocol is configured by UEFI if required > +#define EFI_ACPI_6_0_GICC_STRUCTURE_INIT(GicId, AcpiCpuUid, Mpidr, Flags, > PmuIrq, \ > + GicBase, GicVBase, GicHBase, GsivId, GicRBase) > \ > + { > \ > + EFI_ACPI_6_0_GIC, sizeof (EFI_ACPI_6_0_GIC_STRUCTURE), > EFI_ACPI_RESERVED_WORD, \ > + GicId, AcpiCpuUid, Flags, 0, PmuIrq, 0, GicBase, GicVBase, GicHBase, > \ > + GsivId, GicRBase, Mpidr > \ > + } > + > #define EFI_ACPI_6_0_GIC_MSI_FRAME_INIT(GicMsiFrameId, PhysicalBaseAddress, > Flags, SPICount, SPIBase) \ > { \ > EFI_ACPI_6_0_GIC_MSI_FRAME, sizeof > (EFI_ACPI_6_0_GIC_MSI_FRAME_STRUCTURE), EFI_ACPI_RESERVED_WORD, \ > GicMsiFrameId, PhysicalBaseAddress, Flags, SPICount, SPIBase \ > } > > +#define EFI_ACPI_6_0_GIC_REDISTRIBUTOR_INIT(RedisRegionAddr, > RedisDiscLength) \ > + { \ > + EFI_ACPI_6_0_GICR, sizeof (EFI_ACPI_6_0_GICR_STRUCTURE), 0, > RedisRegionAddr, RedisDiscLength \ > + } > + > // > // SBSA Generic Watchdog > // > -- > 2.6.3 > > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
