Hi Jiaxin, No objections.
Thanks, Sriram. -----Original Message----- From: Wu, Jiaxin [mailto:[email protected]] Sent: Tuesday, February 16, 2016 9:07 AM To: Subramanian, Sriram (EG Servers Platform SW); El-Haj-Mahmoud, Samer; Hegde, Nagaraj P; Zimmer, Vincent; Kinney, Michael D; Li, Ruth; Ye, Ting; Fu, Siyuan; [email protected] Subject: Using PCD to set default policy for IPv4/IPv6 Hi all, Below is the descriptions about the default policy for IPv4/IPv6 in latest UEFI Spec (Version 2.6). << P1472: The EFI_IP4_CONFIG2_POLICY defines the general configuration policy the EFI IPv4 Configuration II Protocol supports. The default policy for a newly detected communication device is beyond the scope of this document. An implementation might leave it to platform to choose the default policy.>> << P1510: The EFI_IP6_CONFIG_POLICY defines the general configuration policy the EFI IPv6 Configuration Protocol supports. The default policy for a newly detected communication device is beyond the scope of this document. An implementation might leave it to platform to choose the default policy.>> So, I propose to introduce PCD to leave it to platform to choose the default policy. That's meaningful to make the source code consistent with UEFI Spec. Detailed see below: ## Ip4Config2 Policy Type configuration. # 01 = The configuration policy is Ip4Config2PolicyStatic # 02 = The configuration policy is Ip4Config2PolicyDhcp # @Prompt Type Value of Ip4Config2 Policy. gEfiMdeModulePkgTokenSpaceGuid.PcdIp4Config2PolicyType|2|UINT8|0x10000002 ## Ip6Config Policy Type configuration. # 01 = The configuration policy is Ip6ConfigPolicyManual # 02 = The configuration policy is Ip6ConfigPolicyAutomatic # @Prompt Type Value of Ip6Config Policy. gEfiNetworkPkgTokenSpaceGuid.PcdIp6ConfigPolicyType|2|UINT8|0x10000002 Do you have any opinion? If there is no objection, I will create the corresponding patches to fix it. Thanks. Jiaxin _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
