On Tue, Feb 16, 2016 at 06:51:45PM +0100, Laszlo Ersek wrote: > On 02/16/16 17:36, Jeremy Linton wrote: > > |Not wishing to influence the discussion, just out of curiosity: Jeremy > > |mentions "numerous other BlockIo protocol providers in edk2 bounce IO > > |operations rather than simply allowing them to fail" -- can we see some > > |examples? I wonder if, upon seeing that code, we could use "git blame" > > |to find out *why* those workarounds had been introduced. > > > > It's the same case, grub2 fails to honor the alignment requirements. > > > > OvmfPkg/XenPvBlkDxe/BlockIo.c > > > > I thought when I originally posted that I had found a couple more > > cases, but then when talking to Leif about it a while back, that was > > the one case I found. > > // > // Grub2 does not appear to respect IoAlign of 512, so reallocate the > // buffer here. > // > > That's not an example that makes me especially happy. In fact, now that > I know about it, I think I'll only tolerate it in OvmfPkg because it's > related to Xen. (And because it's already there.) > > I'm actually pretty disappointed. The above XenPvBlkDxe code was > committed to edk2 in October 2014 (5de8a35c62406), but grub2 has the bug > to *this day*. If you grep the grub2 code at 25492a0f047c for > "io_align", the only hit is in the structure definition, in > "include/grub/efi/api.h". > > Apparently, noone has bothered in the past ~1.5 years to report and fix > the bug in grub2, despite the bugfix looking quite manageable.
https://lists.gnu.org/archive/html/grub-devel/2016-02/msg00166.html / Leif _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
