Reviewed-by: Jaben Carsey <[email protected]> -Jaben
Sent from my iPad. > On Feb 21, 2016, at 6:49 PM, Qiu, Shumin <[email protected]> wrote: > > Do NULL pointer check before the pointer is used to avoid dereferenced. > > Cc: Jaben Carsey <[email protected]> > Cc: Ruiyu Ni <[email protected]> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Qiu Shumin <[email protected]> > --- > ShellPkg/Library/UefiShellLib/UefiShellLib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ShellPkg/Library/UefiShellLib/UefiShellLib.c > b/ShellPkg/Library/UefiShellLib/UefiShellLib.c > index 70852a9..cf89a4a 100644 > --- a/ShellPkg/Library/UefiShellLib/UefiShellLib.c > +++ b/ShellPkg/Library/UefiShellLib/UefiShellLib.c > @@ -4071,7 +4071,7 @@ ShellFileHandleReturnLine( > Status = ShellFileHandleReadLine(Handle, RetVal, &Size, FALSE, Ascii); > > } > - if (Status == EFI_END_OF_FILE && *RetVal != CHAR_NULL) { > + if (Status == EFI_END_OF_FILE && RetVal != NULL && *RetVal != CHAR_NULL) { > Status = EFI_SUCCESS; > } > if (EFI_ERROR(Status) && (RetVal != NULL)) { > -- > 2.7.1.windows.2 > _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
