Will do. Thanks Liming.
-----Original Message----- From: Gao, Liming [[email protected]] Received: Monday, 22 Feb 2016, 6:34AM To: El-Haj-Mahmoud, Samer [[email protected]]; [email protected] [[email protected]] CC: Kinney, Michael D [[email protected]]; El-Haj-Mahmoud, Samer [[email protected]] Subject: RE: [PATCH] MdePkg: Fix CPER GUID definitions to match UEFI spec Samer: I don't suggest to rename EFI_ERROR_SECTION_PROCESSOR_SPECIFIC_GUID to avoid the incompatible change. I suggest to add new PROCESSOR_IA32X64 and PROCESSOR_ARM guid, and keep PROCESSOR_SPECIFIC without change. Besides, I also suggest to name GuidCName like gEfiArmProcessorErrorSectionGuid to match its section title. Last, for UEFI2.6 GUID, please add them below the comments # GUIDs defined in UEFI2.6 in [Guids] section of MdePkg.dec file and group UEFI2.6 GUID definitions together. Thanks Liming -----Original Message----- From: Samer El-Haj-Mahmoud [mailto:[email protected]] Sent: Friday, February 19, 2016 7:35 AM To: [email protected] Cc: Kinney, Michael D <[email protected]>; Gao, Liming <[email protected]>; Samer El-Haj-Mahmoud <[email protected]>; Samer El-Haj-Mahmoud <[email protected]> Subject: [PATCH] MdePkg: Fix CPER GUID definitions to match UEFI spec Rename gEfiProcessorSpecificErrorSectionGuid to gEfiIa32X64ErrorSectionGuid and introduce gEfiArmErrorSectionGuid to match the definition in the UEFI 2.6 specification Table 249. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Samer El-Haj-Mahmoud <[email protected]> --- MdePkg/Include/Guid/Cper.h | 13 +++++++++++-- MdePkg/MdePkg.dec | 5 ++++- 2 files changed, 15 insertions(+), 3 deletions(-) diff --git a/MdePkg/Include/Guid/Cper.h b/MdePkg/Include/Guid/Cper.h index 62493ef..5b3dcef 100644 --- a/MdePkg/Include/Guid/Cper.h +++ b/MdePkg/Include/Guid/Cper.h @@ -2,6 +2,7 @@ GUIDs and definitions used for Common Platform Error Record. Copyright (c) 2011 - 2015, Intel Corporation. All rights reserved.<BR> + (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR> This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at @@ -23,6 +24,8 @@ #define EFI_ERROR_RECORD_SIGNATURE_START SIGNATURE_32('C', 'P', 'E', 'R') #define EFI_ERROR_RECORD_SIGNATURE_END 0xFFFFFFFF +#define EFI_ERROR_RECORD_REVISION 0x0101 + /// /// Error Severity in Error Record Header and Error Section Descriptor ///@{ @@ -137,6 +140,7 @@ typedef struct { /// } EFI_COMMON_ERROR_RECORD_HEADER; +#define EFI_ERROR_SECTION_REVISION 0x0100 /// /// Validity Fields in Error Section Descriptor. /// @@ -161,10 +165,14 @@ typedef struct { { \ 0x9876ccad, 0x47b4, 0x4bdb, { 0xb6, 0x5e, 0x16, 0xf1, 0x93, 0xc4, 0xf3, 0xdb } \ } -#define EFI_ERROR_SECTION_PROCESSOR_SPECIFIC_GUID \ +#define EFI_ERROR_SECTION_PROCESSOR_SPECIFIC_IA32X64_GUID \ { \ 0xdc3ea0b0, 0xa144, 0x4797, { 0xb9, 0x5b, 0x53, 0xfa, 0x24, 0x2b, 0x6e, 0x1d } \ } +#define EFI_ERROR_SECTION_PROCESSOR_SPECIFIC_ARM_GUID \ + { \ + 0xe19e3d16, 0xbc11, 0x11e4, { 0x9c, 0xaa, 0xc2, 0x05, 0x1d, 0x5d, 0x46, 0xb0 } \ + } #define EFI_ERROR_SECTION_PLATFORM_MEMORY_GUID \ { \ 0xa5bc1114, 0x6f64, 0x4ede, { 0xb8, 0x63, 0x3e, 0x83, 0xed, 0x7c, 0x83, 0xb1 } \ @@ -1177,7 +1185,8 @@ extern EFI_GUID gEfiEventNotificationTypeBootGuid; extern EFI_GUID gEfiEventNotificationTypeDmarGuid; extern EFI_GUID gEfiProcessorGenericErrorSectionGuid; -extern EFI_GUID gEfiProcessorSpecificErrorSectionGuid; +extern EFI_GUID gEfiIa32X64ErrorSectionGuid; +extern EFI_GUID gEfiArmErrorSectionGuid; extern EFI_GUID gEfiPlatformMemoryErrorSectionGuid; extern EFI_GUID gEfiPlatformMemory2ErrorSectionGuid; extern EFI_GUID gEfiPcieErrorSectionGuid; diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index c49f1ce..3c1c8e9 100644 --- a/MdePkg/MdePkg.dec +++ b/MdePkg/MdePkg.dec @@ -6,6 +6,7 @@ # # Copyright (c) 2007 - 2016, Intel Corporation. All rights reserved.<BR> # Portions copyright (c) 2008 - 2009, Apple Inc. All rights reserved.<BR> +# (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR> # # This program and the accompanying materials are licensed and made available under # the terms and conditions of the BSD License which accompanies this distribution. @@ -427,9 +428,11 @@ gEfiProcessorGenericErrorSectionGuid = { 0x9876ccad, 0x47b4, 0x4bdb, { 0xb6, 0x5e, 0x16, 0xf1, 0x93, 0xc4, 0xf3, 0xdb }} ## Include/Guid/Cper.h - gEfiProcessorSpecificErrorSectionGuid = { 0xdc3ea0b0, 0xa144, 0x4797, { 0xb9, 0x5b, 0x53, 0xfa, 0x24, 0x2b, 0x6e, 0x1d }} + gEfiIa32X64ErrorSectionGuid = { 0xdc3ea0b0, 0xa144, 0x4797, { 0xb9, 0x5b, 0x53, 0xfa, 0x24, 0x2b, 0x6e, 0x1d }} ## Include/Guid/Cper.h + gEfiArmErrorSectionGuid = { 0xe19e3d16, 0xbc11, 0x11e4, { 0x9c, 0xaa, 0xc2, 0x05, 0x1d, 0x5d, 0x46, 0xb0 }} + ## Include/Guid/Cper.h gEfiPlatformMemoryErrorSectionGuid = { 0xa5bc1114, 0x6f64, 0x4ede, { 0xb8, 0x63, 0x3e, 0x83, 0xed, 0x7c, 0x83, 0xb1 }} ## Include/Guid/Cper.h -- 2.6.3.windows.1 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
