Hi Laszlo, Thank you very much for giving me the comment and information! I will pay attention to this!
Thanks, Dandan -----Original Message----- From: Laszlo Ersek [mailto:[email protected]] Sent: Monday, February 22, 2016 6:18 PM To: Bi, Dandan; [email protected] Cc: Gao, Liming; Dong, Eric Subject: Re: [PATCH v2] MdeModulePkg: HiiDatabaseDxe: HiiStringToImage() should not overwrite BltX On 02/22/16 01:48, Dandan Bi wrote: > v2: Modify the subject to make clear the change of this patch. > > when has newline to draw, should not overwrite the BltX to 0, instead > should keep the BltX value that pass into StringToImage function. > > Cc: Liming Gao <[email protected]> > Cc: Eric Dong <[email protected]> > Cc: Laszlo Ersek <[email protected]> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Dandan Bi <[email protected]> > --- > MdeModulePkg/Universal/HiiDatabaseDxe/Font.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/Font.c > b/MdeModulePkg/Universal/HiiDatabaseDxe/Font.c > index 4b70b99..56b30ff 100644 > --- a/MdeModulePkg/Universal/HiiDatabaseDxe/Font.c > +++ b/MdeModulePkg/Universal/HiiDatabaseDxe/Font.c > @@ -1,10 +1,10 @@ > /** @file > Implementation for EFI_HII_FONT_PROTOCOL. > > > -Copyright (c) 2007 - 2015, Intel Corporation. All rights > reserved.<BR> > +Copyright (c) 2007 - 2016, Intel Corporation. All rights > +reserved.<BR> > This program and the accompanying materials are licensed and made > available under the terms and conditions of the BSD License which > accompanies this distribution. The full text of the license may be > found at http://opensource.org/licenses/bsd-license.php > > @@ -2154,13 +2154,12 @@ HiiStringToImage ( > } > } > > NextLine: > // > - // Recalculate the start point of X/Y axis to draw multi-lines with the > order of top-to-down > + // Recalculate the start point of Y axis to draw multi-lines with > + the order of top-to-down > // > - BltX = 0; > BltY += RowInfo[RowIndex].LineHeight; > > RowIndex++; > Index = NextIndex; > > For this patch: Acked-by: Laszlo Ersek <[email protected]> In general: v2, v3, ..., differences are best marked in the "notes" section of the patch, not in the commit message itself. Please refer to the following two points in the wiki: (1) git config notes.rewriteRef refs/notes/commits https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-05 (2) https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-30 Thanks Laszlo _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
