I discussed with Module owner. Below is summary for MdeModulePkg: 1) PCD Name: We suggest to use PcdDxeIplSwitchToLongMode as indicator that PEI is 32 bit and DXE is 64 bit for X86 platform. It might be not clear stated in PCD description, but it is the intent when this is introduced. We suggest to define this to be FALSE for ARM, so that our core module can use it. (Confirmed with Liming Gao)
2) AcpiTableDxe: As Star Zeng mentioned, we need make sure FACS is allocate below 4G when PcdDxeIplSwitchToLongMode is set, because it is used by S3Resume. 3) UefiBootManagerLib: As Ruiyu Ni mentioned, we need make allocate L"PerfDataMemAddr" below 4G for when PcdDxeIplSwitchToLongMode is set, because it is used by S3Resume. 4) BootGraphicsResourceTableDxe: There is no need to add 4G limitation, we can remove that directly. (Confirmed with Chao Zhang) 5) FirmwarePerformanceDataTableDxe: We can check PcdDxeIplSwitchToLongMode to allocate Below4G memory for mAcpiS3PerformanceTable which is used in S3. And we can remove 4G limitation for mAcpiBootPerformanceTable directly. (Confirmed with Chao Zhang) 6) PiDxeS3BootScriptLib: We can check PcdDxeIplSwitchToLongMode for S3TableBase and NewS3TableBase which is used in S3. (Confirmed with Star Zeng) 7) BootScriptExecutorDxe: We can check PcdDxeIplSwitchToLongMode for FfsBuffer and BootScriptExecutorBuffer which is used in S3. (Confirmed with Star Zeng) 8) CapsuleRuntimeDxe: Already check PcdDxeIplSwitchToLongMode. No update needed. (Confirmed with Star Zeng) BTW: We are trying not use IntelFrameworkModulePkg. If there is replacement in MdeModulePkg, we suggest use the one in MdeModulePkg, for example, BDS or ACPI. Thank you Yao Jiewen From: Ard Biesheuvel [mailto:[email protected]] Sent: Monday, February 22, 2016 8:43 PM To: Yao, Jiewen Cc: Ni, Ruiyu; Laszlo Ersek; [email protected]; Tian, Feng; Zeng, Star; [email protected]; [email protected]; Fan, Jeff; Gao, Liming Subject: Re: [edk2] [PATCH v3 2/4] IntelFrameworkModulePkg: BdsDxe: only allocate below 4 GB if needed On 22 February 2016 at 13:40, Yao, Jiewen wrote: > I did a search on current MdeModulePkg. I found there are more modules > allocating Below4G memory. > > Besides BDS, we have BootGraphicsResourceTableDxe, > BootScriptExecutorDxe, FirmwarePerformanceDataTableDxe, PiDxeS3BootScriptLib, > CapsuleRuntimeDxe. > > > > BootGraphicsResourceTableDxe – I am not clear. > > CapsuleRuntimeDxe – Below4G is designed for PEI capsule. Or we do not > need such capability. > > BootScriptExecutorDxe, FirmwarePerformanceDataTableDxe, > PiDxeS3BootScriptLib > - data need to be access in PEI phase. > > > > I think we might need more clean up for 32bit PEI. > Agreed. > I am still thinking if we can reuse old Pcd – we can clarify in PCD > description – it is only for 32bit PEI and 64bit DXE. > > Or a new PCD, and name to Pcd32BitPei? Please allow me collect more > feedback on that. > OK > In order to separate 32bit PEI issue from ACPI issue, I think we can > check in ACPI patch at first, if you want. > Should I wait for the maintainers of MdeModulePkg to give their Reviewed-by ? _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
