Great. I will sync-up these changes and follow the windows / VS toolchain validations.
Best Regards & Thanks, LONG, Qin > -----Original Message----- > From: David Woodhouse [mailto:[email protected]] > Sent: Thursday, February 25, 2016 10:05 AM > To: Laszlo Ersek; edk2-devel-01 > Cc: Dong, Eric; Cecil Sheng; Ye, Ting; Qiu, Shumin; Long, Qin; Gao, Liming; > Yao, > Jiewen; Daryl McDaniel; Carsey, Jaben; Samer El-Haj-Mahmoud > Subject: Re: [edk2] [PATCH 0/4] free(NULL) and realloc(NULL, size) > conformance improvements > > On Wed, 2016-02-24 at 22:13 +0100, Laszlo Ersek wrote: > > The free() wrapper in BaseCryptLib has a bug that has been triggered > > by David's recent OpenSSL work. The series fixes the bug, plus > > more instances of the same. > > Should we not just fix the underlying FreePool() function to do the > sane thing. > > Anyway, I've rebased my tree on top of yours, split up the patch > changes into separate bisectable commits, and pushed my tree out again > to http://git.infradead.org/users/dwmw2/edk2.git > > Both Cryptest.efi and the test boot of Fedora 22 are working correctly > at all stages. > > Laszlo Ersek (4): > CryptoPkg: BaseCryptLib: support free(NULL) > > CryptoPkg: RuntimeCryptLib: support free(NULL) > CryptoPkg: > RuntimeCryptLib: support realloc(NULL, size) > MdeModulePkg: > RegularExpressionDxe: support free(NULL) > > David Woodhouse (14): > CryptoPkg: Use OpenSSL include directory directly > CryptoPkg/OpensslLib: Include complete copy of opensslconf.h > CryptoPkg/OpensslLib: Regenerate OpenSSL patch > CryptoPkg/OpensslLib: Switch to upstream fix for OpenSSL RT#4175 > CryptoPkg/OpensslLib: Switch to upstream fix for OpenSSL RT#3964 > CryptoPkg/OpensslLib: Switch to upstream fix for OpenSSL RT#3628 > CryptoPkg/OpensslLib: Switch to upstream fix for OpenSSL RT#3955 > CryptoPkg/OpensslLib: Switch to upstream fix for OpenSSL RT#3674 > CryptoPkg/OpensslLib: Switch to upstream fix for OpenSSL RT#3951 > CryptoPkg/OpensslLib: Switch to upstream fix for OpenSSL RT#3992 > CryptoPkg/OpensslLib: Switch to upstream fix for OpenSSL RT#3969 > CryptoPkg/OpensslLib: Automatically configure OpenSSL and generate > file > list > CryptoPkg: Support building with OpenSSL HEAD (1.1.0-devel) > CryptoPkg: Abuse internal headers to make OpenSSL HEAD build work > > Again, the final two commits aren't ready yet. But the rest probably > are if they build OK on Windows. > > I do still want to kill that -w. And why in $DEITY's name do we not > already have -nostdinc in our CFLAGS for the whole EDK2 build? > > -- > David Woodhouse Open Source Technology Centre > [email protected] Intel Corporation _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
