Reviewed-by: Jaben Carsey <[email protected]>

> -----Original Message-----
> From: Qiu, Shumin
> Sent: Thursday, February 25, 2016 10:54 PM
> To: [email protected]
> Cc: Qiu, Shumin <[email protected]>; Carsey, Jaben
> <[email protected]>; Ni, Ruiyu <[email protected]>
> Subject: [PATCH] ShellPkg: Fix unexpected behavior of mouse cursor in
> Editor.
> Importance: High
> 
> USB mouse cursor cannot move unless the left button is down. The patch
> refresh the FileBuffer of Editor every time when the 'MainEditorRefresh'
> is called to fix this bug.
> 
> Cc: Jaben Carsey <[email protected]>
> Cc: Ruiyu Ni <[email protected]>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Qiu Shumin <[email protected]>
> ---
>  ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/MainTextEditor.c | 7
> ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/MainTextEditor.c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/MainTextEditor.c
> index f972c37..4eb7d9e 100644
> --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/MainTextEditor.c
> +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/MainTextEditor.c
> @@ -1,7 +1,7 @@
>  /** @file
>    Implements editor interface functions.
> 
> -  Copyright (c) 2005 - 2014, Intel Corporation. All rights reserved. <BR>
> +  Copyright (c) 2005 - 2016, Intel Corporation. All rights reserved. <BR>
>    This program and the accompanying materials
>    are licensed and made available under the terms and conditions of the BSD
> License
>    which accompanies this distribution.  The full text of the license may be
> found at
> @@ -1617,8 +1617,8 @@ MainEditorRefresh (
> 
>      MainTitleBarRefresh (MainEditor.FileBuffer->FileName,
> MainEditor.FileBuffer->FileType, MainEditor.FileBuffer->ReadOnly,
> MainEditor.FileBuffer->FileModified, MainEditor.ScreenSize.Column,
> MainEditor.ScreenSize.Row, 0, 0);
>      FileBufferRestorePosition ();
> -    FileBufferRefresh ();
>    }
> +
>    if (EditorFirst
>      || FileBufferBackupVar.FilePosition.Row != FileBuffer.FilePosition.Row
>      || FileBufferBackupVar.FilePosition.Column !=
> FileBuffer.FilePosition.Column
> @@ -1627,13 +1627,14 @@ MainEditorRefresh (
> 
>      StatusBarRefresh (EditorFirst, MainEditor.ScreenSize.Row,
> MainEditor.ScreenSize.Column, MainEditor.FileBuffer->FilePosition.Row,
> MainEditor.FileBuffer->FilePosition.Column, MainEditor.FileBuffer-
> >ModeInsert);
>      FileBufferRestorePosition ();
> -    FileBufferRefresh ();
>    }
> 
>    if (EditorFirst) {
>      FileBufferRestorePosition ();
>    }
> 
> +  FileBufferRefresh ();
> +
>    //
>    // EditorFirst is now set to FALSE
>    //
> --
> 2.7.1.windows.2

_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to