Reviewed-by: Michael Kinney <[email protected]> Mike
> -----Original Message----- > From: edk2-devel [mailto:[email protected]] On Behalf Of Hao Wu > Sent: Friday, February 26, 2016 2:53 AM > To: [email protected]; Kinney, Michael D <[email protected]>; > Fan, Jeff > <[email protected]> > Cc: Wu, Hao A <[email protected]> > Subject: [edk2] [PATCH] UefiCpuPkg/Cpuid: Fix GCC build error > > define PRINT_BIT_FIELD(Variable, FieldName) \ > Print (L"%5a%42a: %x\n", #Variable, #FieldName, \ > ##Variable.Bits.##FieldName); > > The above definition in UefiCpuPkg/Application/Cpuid/Cpuid.c > will cause GCC build error. > > Fix it with: > > define PRINT_BIT_FIELD(Variable, FieldName) \ > Print (L"%5a%42a: %x\n", #Variable, #FieldName, \ > Variable.Bits.FieldName); > > The '.' has its origin meaning as a member operator in the define > statement. Thus, the token-pasting operator '##' is not necessary here. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Hao Wu <[email protected]> > --- > UefiCpuPkg/Application/Cpuid/Cpuid.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/UefiCpuPkg/Application/Cpuid/Cpuid.c > b/UefiCpuPkg/Application/Cpuid/Cpuid.c > index f82e43f..366c3ca 100644 > --- a/UefiCpuPkg/Application/Cpuid/Cpuid.c > +++ b/UefiCpuPkg/Application/Cpuid/Cpuid.c > @@ -21,7 +21,7 @@ > /// Macro used to display the value of a bit field in a register returned by > CPUID. > /// > #define PRINT_BIT_FIELD(Variable, FieldName) \ > - Print (L"%5a%42a: %x\n", #Variable, #FieldName, > ##Variable.Bits.##FieldName); > + Print (L"%5a%42a: %x\n", #Variable, #FieldName, Variable.Bits.FieldName); > > /// > /// Macro used to display the value of a register returned by CPUID. > -- > 1.9.5.msysgit.0 > > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
