On 02/29/16 20:42, Leif Lindholm wrote:
> The definition of DEBUG_LOADFILE was incorrectly described as "UNDI
> Driver". Correct this to align with MdePkg.dec.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Leif Lindholm <[email protected]>
> ---
>  MdePkg/Include/Library/DebugLib.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MdePkg/Include/Library/DebugLib.h 
> b/MdePkg/Include/Library/DebugLib.h
> index 219d147..86bb71f 100644
> --- a/MdePkg/Include/Library/DebugLib.h
> +++ b/MdePkg/Include/Library/DebugLib.h
> @@ -48,7 +48,7 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER 
> EXPRESS OR IMPLIED.
>  #define DEBUG_BLKIO     0x00001000  // BlkIo Driver
>  #define DEBUG_NET       0x00004000  // SNI Driver
>  #define DEBUG_UNDI      0x00010000  // UNDI Driver
> -#define DEBUG_LOADFILE  0x00020000  // UNDI Driver
> +#define DEBUG_LOADFILE  0x00020000  // LoadFile
>  #define DEBUG_EVENT     0x00080000  // Event messages
>  #define DEBUG_GCD       0x00100000  // Global Coherency Database changes
>  #define DEBUG_CACHE     0x00200000  // Memory range cachability changes
> 

As far as I can see, DEBUG_LOADFILE is nowhere used in the open source
tree (neither is EFI_D_LOADFILE); but it does match MdePkg.dec.

Reviewed-by: Laszlo Ersek <[email protected]>

I suggest to fix the typo in "SNI Driver" too -- it should be "SNP
driver" -- verified by grepping for '(EFI_D_NET|DEBUG_NET)' [*] -- but I
don't insist. :)

[*] EmbeddedPkg/Drivers/Lan9118Dxe
    IntelFrameworkModulePkg/Csm/BiosThunk/Snp16Dxe
    MdeModulePkg/Universal/Network/SnpDxe

Thanks
Laszlo
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to