On 03/01/16 15:18, Leif Lindholm wrote: > On Tue, Mar 01, 2016 at 02:10:37PM +0000, Ryan Harkin wrote: >> On 1 March 2016 at 10:11, Leif Lindholm <[email protected]> wrote: >>> On Tue, Mar 01, 2016 at 11:00:45AM +0100, Ard Biesheuvel wrote: >>>> On 1 March 2016 at 10:58, Laszlo Ersek <[email protected]> wrote: >>>>> Public branch: >>>>> <https://github.com/lersek/edk2/commits/debugh_comment_fix>. >>>>> >>>>> Cc: Ard Biesheuvel <[email protected]> >>>>> Cc: Jordan Justen <[email protected]> >>>>> Cc: Leif Lindholm <[email protected]> >>>>> Cc: Liming Gao <[email protected]> >>>>> Cc: Michael Kinney <[email protected]> >>>>> >>>> >>>> Looks ok to me >>>> >>>> For where you need it: >>>> Reviewed-by: Ard Biesheuvel <[email protected]> >>> >>> Apart from 2/6 (which can be dropped), ditto: >>> Reviewed-by: Leif Lindholm <[email protected]> >>> >> >> To go against the grain, what's the reason for having this info >> duplicated across multiple files as comments? >> >> Without knowing the reason for it's being, I'd find the delete key >> more useful in this scenario. > > Mainly that it is very handy to have this information nearby rather > than having to cross-reference against a random when you're looking to > set individual bits in a diagnostics facilities variable... > > Certainly this particular snippet would be an excellent candidate to > reduce down to being in a single .dsc with your configuration file > consolidation plans. But until then, I think the handiness motivates > the duplication.
It does. Thanks Laszlo > > / > Leif > >>>>> Laszlo Ersek (6): >>>>> MdePkg: DebugLib: more cleanup for log level comments in lib class >>>>> header >>>>> ArmPlatformPkg/ArmVExpressPkg: sync log level comments to DebugLib.h >>>>> ArmVirtPkg: sync log level comments to DebugLib.h >>>>> BeagleBoardPkg: sync log level comments to DebugLib.h >>>>> Omap35xxPkg: sync log level comments to DebugLib.h >>>>> OvmfPkg: copy log level comments from DebugLib.h >>>>> >>>>> ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc | 14 +++++++------ >>>>> ArmVirtPkg/ArmVirt.dsc.inc | 8 +++---- >>>>> BeagleBoardPkg/BeagleBoardPkg.dsc | 16 ++++++++------ >>>>> Omap35xxPkg/Omap35xxPkg.dsc | 16 ++++++++------ >>>>> OvmfPkg/OvmfPkgIa32.dsc | 22 >>>>> ++++++++++++++++++++ >>>>> OvmfPkg/OvmfPkgIa32X64.dsc | 22 >>>>> ++++++++++++++++++++ >>>>> OvmfPkg/OvmfPkgX64.dsc | 22 >>>>> ++++++++++++++++++++ >>>>> MdePkg/Include/Library/DebugLib.h | 9 ++++---- >>>>> 8 files changed, 103 insertions(+), 26 deletions(-) >>>>> >>>>> -- >>>>> 1.8.3.1 >>>>> >>> _______________________________________________ >>> edk2-devel mailing list >>> [email protected] >>> https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
