Samer: The minor comment. Copyright line in header file has the trailing space. You can run BaseTools\Scripts\PatchCheck.py to check it first.
Other part are good. Reviewed-by: Liming Gao <[email protected]> Thanks Liming > -----Original Message----- > From: Samer El-Haj-Mahmoud [mailto:[email protected]] > Sent: Friday, March 04, 2016 9:15 AM > To: [email protected] > Cc: Gao, Liming; Kinney, Michael D; Samer El-Haj-Mahmoud; Samer El-Haj- > Mahmoud > Subject: [PATCH v2] MdePkg: Fix CPER GUID definitions to match UEFI spec > > Add gEfiIa32X64ProcessorErrorSectionGuid and > gEfiArmProcessorErrorSectionGuid to > match the definition in the UEFI 2.6 specification Table 249. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Samer El-Haj-Mahmoud <[email protected]> > --- > MdePkg/Include/Guid/Cper.h | 17 ++++++++++++++++- > MdePkg/MdePkg.dec | 7 +++++++ > 2 files changed, 23 insertions(+), 1 deletion(-) > > diff --git a/MdePkg/Include/Guid/Cper.h b/MdePkg/Include/Guid/Cper.h > index 62493ef..7286996 100644 > --- a/MdePkg/Include/Guid/Cper.h > +++ b/MdePkg/Include/Guid/Cper.h > @@ -2,6 +2,7 @@ > GUIDs and definitions used for Common Platform Error Record. > > Copyright (c) 2011 - 2015, Intel Corporation. All rights reserved.<BR> > + (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR> > This program and the accompanying materials > are licensed and made available under the terms and conditions of the BSD > License > which accompanies this distribution. The full text of the license may be > found at > @@ -11,7 +12,7 @@ > WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > EXPRESS OR IMPLIED. > > @par Revision Reference: > - GUIDs defined in UEFI 2.4 Specification. > + GUIDs defined in UEFI 2.6 Specification. > > **/ > > @@ -23,6 +24,8 @@ > #define EFI_ERROR_RECORD_SIGNATURE_START SIGNATURE_32('C', 'P', 'E', > 'R') > #define EFI_ERROR_RECORD_SIGNATURE_END 0xFFFFFFFF > > +#define EFI_ERROR_RECORD_REVISION 0x0101 > + > /// > /// Error Severity in Error Record Header and Error Section Descriptor > ///@{ > @@ -137,6 +140,8 @@ typedef struct { > /// > } EFI_COMMON_ERROR_RECORD_HEADER; > > +#define EFI_ERROR_SECTION_REVISION 0x0100 > + > /// > /// Validity Fields in Error Section Descriptor. > /// > @@ -165,6 +170,14 @@ typedef struct { > { \ > 0xdc3ea0b0, 0xa144, 0x4797, { 0xb9, 0x5b, 0x53, 0xfa, 0x24, 0x2b, 0x6e, > 0x1d } \ > } > +#define EFI_ERROR_SECTION_PROCESSOR_SPECIFIC_IA32X64_GUID \ > + { \ > + 0xdc3ea0b0, 0xa144, 0x4797, { 0xb9, 0x5b, 0x53, 0xfa, 0x24, 0x2b, 0x6e, > 0x1d } \ > + } > +#define EFI_ERROR_SECTION_PROCESSOR_SPECIFIC_ARM_GUID \ > + { \ > + 0xe19e3d16, 0xbc11, 0x11e4, { 0x9c, 0xaa, 0xc2, 0x05, 0x1d, 0x5d, 0x46, > 0xb0 } \ > + } > #define EFI_ERROR_SECTION_PLATFORM_MEMORY_GUID \ > { \ > 0xa5bc1114, 0x6f64, 0x4ede, { 0xb8, 0x63, 0x3e, 0x83, 0xed, 0x7c, 0x83, > 0xb1 } \ > @@ -1178,6 +1191,8 @@ extern EFI_GUID > gEfiEventNotificationTypeDmarGuid; > > extern EFI_GUID gEfiProcessorGenericErrorSectionGuid; > extern EFI_GUID gEfiProcessorSpecificErrorSectionGuid; > +extern EFI_GUID gEfiIa32X64ProcessorErrorSectionGuid; > +extern EFI_GUID gEfiArmProcessorErrorSectionGuid ; > extern EFI_GUID gEfiPlatformMemoryErrorSectionGuid; > extern EFI_GUID gEfiPlatformMemory2ErrorSectionGuid; > extern EFI_GUID gEfiPcieErrorSectionGuid; > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec > index c49f1ce..2da4a92 100644 > --- a/MdePkg/MdePkg.dec > +++ b/MdePkg/MdePkg.dec > @@ -6,6 +6,7 @@ > # > # Copyright (c) 2007 - 2016, Intel Corporation. All rights reserved.<BR> > # Portions copyright (c) 2008 - 2009, Apple Inc. All rights reserved.<BR> > +# (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR> > # > # This program and the accompanying materials are licensed and made > available under > # the terms and conditions of the BSD License which accompanies this > distribution. > @@ -428,6 +429,9 @@ > > ## Include/Guid/Cper.h > gEfiProcessorSpecificErrorSectionGuid = { 0xdc3ea0b0, 0xa144, 0x4797, > { 0xb9, 0x5b, 0x53, 0xfa, 0x24, 0x2b, 0x6e, 0x1d }} > + > + ## Include/Guid/Cper.h > + gEfiIa32X64ProcessorErrorSectionGuid = { 0xdc3ea0b0, 0xa144, 0x4797, > { 0xb9, 0x5b, 0x53, 0xfa, 0x24, 0x2b, 0x6e, 0x1d }} > > ## Include/Guid/Cper.h > gEfiPlatformMemoryErrorSectionGuid = { 0xa5bc1114, 0x6f64, 0x4ede, > { 0xb8, 0x63, 0x3e, 0x83, 0xed, 0x7c, 0x83, 0xb1 }} > @@ -618,6 +622,9 @@ > ## Include/Guid/MemoryAttributesTable.h > gEfiMemoryAttributesTableGuid = { 0xdcfa911d, 0x26eb, 0x469f, {0xa2, > 0x20, 0x38, 0xb7, 0xdc, 0x46, 0x12, 0x20}} > > + ## Include/Guid/Cper.h > + gEfiArmProcessorErrorSectionGuid = { 0xe19e3d16, 0xbc11, 0x11e4, > { 0x9c, 0xaa, 0xc2, 0x05, 0x1d, 0x5d, 0x46, 0xb0 }} > + > # > # GUID defined in PI1.0 > # > -- > 2.6.3.windows.1 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
