On 9 March 2016 at 01:17, Laszlo Ersek <[email protected]> wrote: > On 03/08/16 19:09, David Woodhouse wrote: >> On Tue, 2016-03-08 at 19:00 +0100, Laszlo Ersek wrote: > >>> Or do you recommend that contributors be *allowed* to email pull >>> requests (alongside their patches), and if they do, their pull requests >>> be merged correctly? >> >> Exactly this. They should be *allowed*, and for large submissions it >> should be *recommended* but not mandatory. > > ACK > > (Modulo consensus from other edk2 maintainers, of course.) >
I agree that they should be allowed, but i share the concern that merging puts the burden of fixing up conflicts on the maintainer rather than the contributor, who is arguably in a worse position to assess any potential problems on a seemingly clean merge, especially since merges are much more forgiving than rebases. On top of that, the current crop of Tianocore committers is not entirely on top of things yet as fas as git is concerned, and having non-linear history just because someone couldn't be bothered to do a pull beforehand should also be avoided imo. -- Ard. _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
