Reviewed-by: Michael Kinney <[email protected]>
> -----Original Message----- > From: Fan, Jeff > Sent: Tuesday, March 8, 2016 6:17 PM > To: [email protected] > Cc: Qiu, Shumin <[email protected]>; Kinney, Michael D > <[email protected]> > Subject: [Patch] UefiCpuPkg/Application/Cpuid: Remove unnecessary code check > > gMaximumBasicFunction is set to CPUID_SIGNATURE as below, so removed the > compare code. > UINT32 gMaximumBasicFunction = CPUID_SIGNATURE; > > Cc: Qiu Shumin <[email protected]> > Cc: Michael Kinney <[email protected]> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jeff Fan <[email protected]> > --- > UefiCpuPkg/Application/Cpuid/Cpuid.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/UefiCpuPkg/Application/Cpuid/Cpuid.c > b/UefiCpuPkg/Application/Cpuid/Cpuid.c > index f5268cd..b0624e1 100644 > --- a/UefiCpuPkg/Application/Cpuid/Cpuid.c > +++ b/UefiCpuPkg/Application/Cpuid/Cpuid.c > @@ -179,10 +179,6 @@ CpuidSignature ( > UINT32 Edx; > CHAR8 Signature[13]; > > - if (CPUID_SIGNATURE > gMaximumBasicFunction) { > - return; > - } > - > AsmCpuid (CPUID_SIGNATURE, &Eax, &Ebx, &Ecx, &Edx); > > Print (L"CPUID_SIGNATURE (Leaf %08x)\n", CPUID_SIGNATURE); > -- > 1.9.5.msysgit.0 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
