Reviewed-by: Fu Siyuan <[email protected]> > -----Original Message----- > From: Zhang, Lubo > Sent: Wednesday, March 9, 2016 2:21 PM > To: [email protected] > Cc: Fu, Siyuan <[email protected]>; Wu, Jiaxin <[email protected]> > Subject: [patch] NetworkPkg: Refine the code of shell app under networkPkg. > > refine the code of ifconfig6 and ping6 application. > > Cc: Fu Siyuan <[email protected]> > Cc: Wu Jiaxin <[email protected]> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Zhang Lubo <[email protected]> > --- > NetworkPkg/Application/IfConfig6/IfConfig6.c | 5 +++++ > NetworkPkg/Application/IfConfig6/IfConfig6.h | 5 ----- > NetworkPkg/Application/Ping6/Ping6.c | 5 +++++ > NetworkPkg/Application/Ping6/Ping6.h | 5 ----- > 4 files changed, 10 insertions(+), 10 deletions(-) > > diff --git a/NetworkPkg/Application/IfConfig6/IfConfig6.c > b/NetworkPkg/Application/IfConfig6/IfConfig6.c > index 8bd6243..48c3be3 100644 > --- a/NetworkPkg/Application/IfConfig6/IfConfig6.c > +++ b/NetworkPkg/Application/IfConfig6/IfConfig6.c > @@ -26,10 +26,15 @@ > #include <Protocol/Ip6.h> > #include <Protocol/Ip6Config.h> > > #include "IfConfig6.h" > > +// > +// String token ID of ifconfig6 command help message text. > +// > +GLOBAL_REMOVE_IF_UNREFERENCED EFI_STRING_ID > mStringIfconfig6HelpTokenId = STRING_TOKEN (STR_IFCONFIG6_HELP); > + > EFI_HII_HANDLE mHiiHandle; > > SHELL_PARAM_ITEM mIfConfig6CheckList[] = { > { > L"-b", > diff --git a/NetworkPkg/Application/IfConfig6/IfConfig6.h > b/NetworkPkg/Application/IfConfig6/IfConfig6.h > index 53b6d72..f748971 100644 > --- a/NetworkPkg/Application/IfConfig6/IfConfig6.h > +++ b/NetworkPkg/Application/IfConfig6/IfConfig6.h > @@ -14,15 +14,10 @@ > **/ > > #ifndef _IFCONFIG6_H_ > #define _IFCONFIG6_H_ > > -// > -// String token ID of ifconfig6 command help message text. > -// > -GLOBAL_REMOVE_IF_UNREFERENCED EFI_STRING_ID > mStringIfconfig6HelpTokenId = STRING_TOKEN (STR_IFCONFIG6_HELP); > - > enum { > IfConfig6OpList = 1, > IfConfig6OpSet = 2, > IfConfig6OpClear = 3 > }; > diff --git a/NetworkPkg/Application/Ping6/Ping6.c > b/NetworkPkg/Application/Ping6/Ping6.c > index f1685f7..55314e5 100644 > --- a/NetworkPkg/Application/Ping6/Ping6.c > +++ b/NetworkPkg/Application/Ping6/Ping6.c > @@ -28,10 +28,15 @@ > #include <Protocol/Ip6.h> > #include <Protocol/Ip6Config.h> > > #include "Ping6.h" > > +// > +// String token ID of Ping6 command help message text. > +// > +GLOBAL_REMOVE_IF_UNREFERENCED EFI_STRING_ID > mStringPing6HelpToken = STRING_TOKEN (STR_PING6_HELP); > + > SHELL_PARAM_ITEM Ping6ParamList[] = { > { > L"-l", > TypeValue > }, > diff --git a/NetworkPkg/Application/Ping6/Ping6.h > b/NetworkPkg/Application/Ping6/Ping6.h > index 4660b0e..6f590af 100644 > --- a/NetworkPkg/Application/Ping6/Ping6.h > +++ b/NetworkPkg/Application/Ping6/Ping6.h > @@ -20,15 +20,10 @@ > #define PING6_MAX_SEND_NUMBER 10000 > #define PING6_MAX_BUFFER_SIZE 32768 > #define PING6_ONE_SECOND 10000000 > > // > -// String token ID of Ping6 command help message text. > -// > -GLOBAL_REMOVE_IF_UNREFERENCED EFI_STRING_ID > mStringPing6HelpToken = STRING_TOKEN (STR_PING6_HELP); > - > -// > // A similar amount of time that passes in femtoseconds > // for each increment of TimerValue. It is for NT32 only. > // > #define NTTIMERPERIOD 358049 > > -- > 1.9.5.msysgit.1
_______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
