On 2016-03-14 22:14:14, Ruiyu Ni wrote: > Current implementation only supports legacy region of 440 chip. > When QEMU is launched in Q35 mode using CSM enabled OVMF image, > LegacyBios driver fails to start due to the legacy region > [0xC0000, 0xFFFFF] cannot be written. >
Could you add a note to the commit message when updating the patch? For example, right here in the commit message, you could add: v2: * Update comment for PAM map > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ruiyu Ni <[email protected]> > Cc: Justen Jordan <[email protected]> > Cc: Laszlo Ersek <[email protected]> > --- > // > -// 440 PAM map. > +// 440/Q35 PAM map. > // I guess this comment table changed in v2. Anything else? > + if (PciRead16 (PCI_LIB_ADDRESS(PAM_PCI_BUS, PAM_PCI_DEV, PAM_PCI_FUNC, > PCI_DEVICE_ID_OFFSET)) > + == PAM_DEVICE_ID_Q35) { > + mRegisterValues = mRegisterValuesQ35; > + } else { > + mRegisterValues = mRegisterValues440; > + } > + Can you use PcdOvmfHostBridgePciDevId? -Jordan _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
