On 16 March 2016 at 14:30, Laszlo Ersek <[email protected]> wrote: > On 03/16/16 10:06, Ard Biesheuvel wrote: >> On 15 March 2016 at 14:17, Qiu Shumin <[email protected]> wrote: >>> This patch makes Shell support -nonesting invocation option. This option >>> specifies that EFI_SHELL_PROTOCOL.Execute API nesting of a new Shell >>> instance is optional and dependent on the 'nonesting' Shell environment >>> variable. >>> >>> Difference with previous patch: >>> Do not use "negative" functions names. >>> >>> Contributed-under: TianoCore Contribution Agreement 1.0 >>> Signed-off-by: Jaben Carsey <[email protected]> >>> Reviewed-by: Qiu Shumin <[email protected]> >>> Reviewed-by: Jim Dailey <[email protected]> >> >> >> This patch breaks the build for GCC >> >> 08:25:14 >> /home/buildslave/workspace/leg-virt-tianocore-edk2-upstream/edk2/ShellPkg/Application/Shell/ShellProtocol.c: >> In function 'EfiShellExecute': >> 08:25:14 >> /home/buildslave/workspace/leg-virt-tianocore-edk2-upstream/edk2/ShellPkg/Application/Shell/ShellProtocol.c:1741:14: >> error: variable 'CalleeStatusCode' set but not used >> [-Werror=unused-but-set-variable] >> 08:25:14 EFI_STATUS CalleeStatusCode; >> >> Please fix > > Can you please fix it and push it at once? You have my R-b in advance: > > Reviewed-by: Laszlo Ersek <[email protected]> >
Could the authors/ShellPkg maintainers please follow up on this? The upstream is currently broken for all GCC users Regards, Ard. _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
