> On Mar 17, 2016, at 2:34 PM, Kinney, Michael D <[email protected]> > wrote: > > Andrew, > > I agree that adding UNUSED to Base.h solves the issues that multiple packages > may want to enable that warning and have a way to decorate implementation so > the warning is not generated. > > I did mix two topics in this discussion. One is code review of UNUSED macro, > and the other is an EDK II C Coding Style topic. As long as use of UNUSED > is optional, and each package/module owner gets to decide if use of UNUSED > is required or not, then I am ok with adding the macro to Base.h. > > We may want to add comments above the UNUSED macro in Base.h to provide a > more detailed description that describes that it is optional and if/when it > should be used. > > We will also need to decide if we want any statements in the EDK II C Coding > Style document about use of the UNUSED macro, but that is likely its own > thread. >
Mike, Sounds good to me. Thanks, Andrew Fish > Mike _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
