No. I don't think the UINT32 is for data alignment. Because EFI_SERIAL_IO_MODE isn't decorated by #pragma pack(1), it's naturally aligned.
Regards, Ray From: edk2-devel [mailto:[email protected]] On Behalf Of Heyi Guo Sent: Thursday, March 17, 2016 3:13 PM To: Ni, Ruiyu <[email protected]>; [email protected] Cc: Kinney, Michael D <[email protected]>; Gao, Liming <[email protected]> Subject: Re: [edk2] [RFC 1/3] MdePkg: Add PCD for UART default receive FIFO depth Hi Ruiyu, Does it also mean the type in EFI_SERIAL_IO_MODE is mainly for data alignment? Heyi On 03/17/2016 10:29 AM, Ni, Ruiyu wrote: > Heyi, > I agree with the general idea of the patch to add a PCD for > DefaultReceiveFifoDepth. > > I understand you choose UINT32 for the FIFO depth because the > EFI_SERIAL_IO_MODE.ReceiveFifoDepth is of UINT32 type. > But in real world, I believe UINT16 should be enough. > > Could you please change the PCD type to UINT16? > > Regards, > Ray > > >> -----Original Message----- >> From: edk2-devel [mailto:[email protected]] On Behalf Of Heyi >> Guo >> Sent: Wednesday, March 16, 2016 6:58 PM >> To: [email protected]<mailto:[email protected]> >> Cc: Kinney, Michael D >> <[email protected]<mailto:[email protected]>>; Heyi Guo >> <[email protected]<mailto:[email protected]>>; Gao, Liming >> <[email protected]<mailto:[email protected]>> >> Subject: [edk2] [RFC 1/3] MdePkg: Add PCD for UART default receive FIFO depth >> >> PcdUartDefaultReceiveFifoDepth is added to indicate UART default >> receive FIFO depth. >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Heyi Guo <[email protected]<mailto:[email protected]>> >> Cc: Michael D Kinney >> <[email protected]<mailto:[email protected]>> >> Cc: Liming Gao <[email protected]<mailto:[email protected]>> >> --- >> MdePkg/MdePkg.dec | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec >> index 47a1cd7..87ec552 100644 >> --- a/MdePkg/MdePkg.dec >> +++ b/MdePkg/MdePkg.dec >> @@ -2074,6 +2074,10 @@ >> # @ValidRange 0x80000001 | 0 - 4 >> gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|0|UINT8|0x00000024 >> >> + ## Indicates the receive FIFO depth of UART controller.<BR><BR> >> + # @Prompt Default UART Receive FIFO Depth. >> + >> gEfiMdePkgTokenSpaceGuid.PcdUartDefaultReceiveFifoDepth|1|UINT32|0x00000030 >> + >> ## Error level for hardware recorder. >> # If value 0, platform does not support feature of hardware error record. >> # @Prompt Error Level For Hardware Recorder >> -- >> 2.7.0 >> >> _______________________________________________ >> edk2-devel mailing list >> [email protected]<mailto:[email protected]> >> https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected]<mailto:[email protected]> https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
