On Fri, 2016-03-18 at 17:53 +0100, Laszlo Ersek wrote: > > (1) The commit message uses at least one non-ASCII character, the EM > DASH (U+2014). Can you please replace it with a "--"? Yes, I know you > hate me for asking this. Please just write me off as stupid and replace > the character.
No. This isn't 1994. If you wish to change it, go ahead. Don't ask me to do stupid things for no good reason. > (2) In the edk2 coding style, initialization of local variables is not > permitted. Can you please add an assignment instead? Er, really? What insanity is this? Where did these guidelines come from and can they be fixed? Why would initialisation of local variables *ever* be frowned upon? How do they make this stuff up? > (3) I tried to apply your patch nonetheless. It doesn't apply. I looked > at the patch email that I saved from Thunderbird. The code section of > the email contains =C2=A0 quoted-printable sequences. Since the charset > is UTF-8 (according to the Content-Type header), 0xC2 0xA0 translates to > U+00A0, "NO-BREAK SPACE". Hm, that would appear to be an Evolution bug. I think it triggers when lines have trailing whitespace. I'll investigate. Thanks for pointing it out. I can put it in a PR if you prefer... :) -- dwmw2
smime.p7s
Description: S/MIME cryptographic signature
_______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
