The BootMaintenanceManagerUiLib use ChooseFile() from FileExplorerLib to select files. And the third parameter in ChooseFile() is CHOOSE_HANDLER, per the definition of CHOOSE_HANDLER, it must use EFIAPI as the calling convention. But the calling convention was not specified for following handlers: CreateBootOptionFromFile, CreateDriverOptionFromFile, BootFromFile. Now specifies the calling convention for those functions.
Cc: Liming Gao <[email protected]> Cc: Eric Dong <[email protected]> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi <[email protected]> --- .../Library/BootMaintenanceManagerUiLib/BootMaintenanceManager.h | 3 +++ MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootOption.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManager.h b/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManager.h index 2c93446..d607314 100644 --- a/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManager.h +++ b/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManager.h @@ -1303,10 +1303,11 @@ BootMaintCallback ( @retval TRUE Exit caller function. @retval FALSE Not exit caller function. **/ BOOLEAN +EFIAPI CreateBootOptionFromFile ( IN EFI_DEVICE_PATH_PROTOCOL *FilePath ); /** @@ -1316,10 +1317,11 @@ CreateBootOptionFromFile ( @retval TRUE Exit caller function. @retval FALSE Not exit caller function. **/ BOOLEAN +EFIAPI CreateDriverOptionFromFile ( IN EFI_DEVICE_PATH_PROTOCOL *FilePath ); /** @@ -1330,10 +1332,11 @@ CreateDriverOptionFromFile ( @retval TRUE Exit caller function. @retval FALSE Not exit caller function. **/ BOOLEAN +EFIAPI BootFromFile ( IN EFI_DEVICE_PATH_PROTOCOL *FilePath ); // diff --git a/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootOption.c b/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootOption.c index 0bd3170..7a014c9 100644 --- a/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootOption.c +++ b/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootOption.c @@ -855,10 +855,11 @@ GetDriverOrder ( @retval TRUE Exit caller function. @retval FALSE Not exit caller function. **/ BOOLEAN +EFIAPI BootFromFile ( IN EFI_DEVICE_PATH_PROTOCOL *FilePath ) { EFI_BOOT_MANAGER_LOAD_OPTION BootOption; @@ -927,10 +928,11 @@ ReSendForm( @retval TRUE Exit caller function. @retval FALSE Not exit caller function. **/ BOOLEAN +EFIAPI CreateBootOptionFromFile ( IN EFI_DEVICE_PATH_PROTOCOL *FilePath ) { return ReSendForm(FilePath, FORM_BOOT_ADD_ID); @@ -944,10 +946,11 @@ CreateBootOptionFromFile ( @retval TRUE Exit caller function. @retval FALSE Not exit caller function. **/ BOOLEAN +EFIAPI CreateDriverOptionFromFile ( IN EFI_DEVICE_PATH_PROTOCOL *FilePath ) { return ReSendForm(FilePath, FORM_DRV_ADD_FILE_ID); -- 1.9.5.msysgit.1 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
