On Mon, Mar 21, 2016 at 10:34:17AM +0100, Laszlo Ersek wrote: > On 03/21/16 10:04, Gary Lin wrote: > > The type casting in the ChooseFile is not necessary and it actually > > hided the incompatible handlers from the compiler. > > s/hided/hid/ > > Other than that: series > Reviewed-by: Laszlo Ersek <[email protected]> > > Dandan, if you want me to, I can help commit these patches. > Hi Dandan,
Will you commit the patches? or would you like Laszlo to commit the patches? Gary Lin > Thanks, Gary! > Laszlo > > > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Gary Lin <[email protected]> > > --- > > .../SecureBootConfigDxe/SecureBootConfigImpl.c | 10 > > +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff --git > > a/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigImpl.c > > > > b/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigImpl.c > > index 8ca6d62..e840316 100644 > > --- > > a/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigImpl.c > > +++ > > b/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigImpl.c > > @@ -3590,23 +3590,23 @@ SecureBootCallback ( > > break; > > > > case FORMID_ENROLL_PK_FORM: > > - ChooseFile( NULL, NULL, (CHOOSE_HANDLER) UpdatePKFromFile, &File); > > + ChooseFile (NULL, NULL, UpdatePKFromFile, &File); > > break; > > > > case FORMID_ENROLL_KEK_FORM: > > - ChooseFile( NULL, NULL, (CHOOSE_HANDLER) UpdateKEKFromFile, &File); > > + ChooseFile (NULL, NULL, UpdateKEKFromFile, &File); > > break; > > > > case SECUREBOOT_ENROLL_SIGNATURE_TO_DB: > > - ChooseFile( NULL, NULL, (CHOOSE_HANDLER) UpdateDBFromFile, &File); > > + ChooseFile (NULL, NULL, UpdateDBFromFile, &File); > > break; > > > > case SECUREBOOT_ENROLL_SIGNATURE_TO_DBX: > > - ChooseFile( NULL, NULL, (CHOOSE_HANDLER) UpdateDBXFromFile, &File); > > + ChooseFile (NULL, NULL, UpdateDBXFromFile, &File); > > break; > > > > case SECUREBOOT_ENROLL_SIGNATURE_TO_DBT: > > - ChooseFile( NULL, NULL, (CHOOSE_HANDLER) UpdateDBTFromFile, &File); > > + ChooseFile (NULL, NULL, UpdateDBTFromFile, &File); > > break; > > > > case KEY_SECURE_BOOT_DELETE_PK: > > > > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
