On Thu, 2016-03-24 at 18:31 +0100, Laszlo Ersek wrote:
> On 03/24/16 17:30, James Bottomley wrote:
> > During real world testing I
> > was getting an error with too many entries
> > in db: On my Secure boot
> > laptop, I currently have seven certificates:
> > two Microsoft ones, Three
> > Kernel ones from various distributions, my
> > own Secure Key and a
> > temporary test key.  That gives a total EFI
> > Signature List size of 8317
> > which is over the 0x2000 maximum.
> > 
> > Fix this by setting the PcdMaxAuthVariableSize to 0x2800 (10K) which
> > isn't much of an increase but allows for 9-10 certificates.
> > 
> > Contributed-under: TianoCore Contribution Agreement 1.0
> > Signed-off-by: James Bottomley <james.bottom...@hansenpartnership.com>
> > ---
> >  OvmfPkg/OvmfPkgIa32.dsc    | 1 +
> >  OvmfPkg/OvmfPkgIa32X64.dsc | 1 +
> >  OvmfPkg/OvmfPkgX64.dsc     | 1 +
> >  3 files changed, 3 insertions(+)
> > 
> > diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc
> > index 2635992..c6ad2e9 100644
> > --- a/OvmfPkg/OvmfPkgIa32.dsc
> > +++ b/OvmfPkg/OvmfPkgIa32.dsc
> > @@ -381,6 +381,7 @@
> >    gEfiMdeModulePkgTokenSpaceGuid.PcdPeiCoreMaxFvSupported|6
> >    gEfiMdeModulePkgTokenSpaceGuid.PcdPeiCoreMaxPeimPerFv|32
> >    gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000
> > +  gEfiMdeModulePkgTokenSpaceGuid.PcdMaxAuthVariableSize|0x8000
> >    gEfiMdeModulePkgTokenSpaceGuid.PcdMaxHardwareErrorVariableSize|0x8000
> >    gEfiMdeModulePkgTokenSpaceGuid.PcdVariableStoreSize|0xe000
> >  
> > diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc
> > index e9ffcb4..439f3bf 100644
> > --- a/OvmfPkg/OvmfPkgIa32X64.dsc
> > +++ b/OvmfPkg/OvmfPkgIa32X64.dsc
> > @@ -386,6 +386,7 @@
> >    gEfiMdeModulePkgTokenSpaceGuid.PcdPeiCoreMaxFvSupported|6
> >    gEfiMdeModulePkgTokenSpaceGuid.PcdPeiCoreMaxPeimPerFv|32
> >    gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000
> > +  gEfiMdeModulePkgTokenSpaceGuid.PcdMaxAuthVariableSize|0x2800
> >    gEfiMdeModulePkgTokenSpaceGuid.PcdMaxHardwareErrorVariableSize|0x8000
> >    gEfiMdeModulePkgTokenSpaceGuid.PcdVariableStoreSize|0xe000
> >  
> > diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc
> > index c983a54..74d4814 100644
> > --- a/OvmfPkg/OvmfPkgX64.dsc
> > +++ b/OvmfPkg/OvmfPkgX64.dsc
> > @@ -386,6 +386,7 @@
> >    gEfiMdeModulePkgTokenSpaceGuid.PcdPeiCoreMaxFvSupported|6
> >    gEfiMdeModulePkgTokenSpaceGuid.PcdPeiCoreMaxPeimPerFv|32
> >    gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000
> > +  gEfiMdeModulePkgTokenSpaceGuid.PcdMaxAuthVariableSize|0x8000
> >    gEfiMdeModulePkgTokenSpaceGuid.PcdMaxHardwareErrorVariableSize|0x8000
> >    gEfiMdeModulePkgTokenSpaceGuid.PcdVariableStoreSize|0xe000
> 
> Patch looks good, except you forgot to update the values in the
> OvmfPkgIa32.dsc and OvmfPkgX64.dsc files; they still say 0x8000. Please
> send a v3.

Heh, that's because I usually don't commit a patch before sending, so I
forgot to amend the other two values.  I'll update.

James


_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to