There are use cases for it in platform customizations of BDS behavior... Is there an issue in exposing the function through the library API?
-----Original Message----- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ni, Ruiyu Sent: Tuesday, March 29, 2016 7:52 PM To: El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com>; Palmer, Thomas <thomas.pal...@hpe.com>; edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com>; Zeng, Star <star.z...@intel.com> Subject: Re: [edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: Expose BmLoadOption function Thomas, May I know the purpose to expose this function? Regards, Ray >-----Original Message----- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >El-Haj-Mahmoud, Samer >Sent: Wednesday, March 30, 2016 6:12 AM >To: Palmer, Thomas <thomas.pal...@hpe.com>; edk2-devel@lists.01.org >Cc: Tian, Feng <feng.t...@intel.com>; Zeng, Star <star.z...@intel.com> >Subject: Re: [edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: Expose >BmLoadOption function > >Reviewed-by: Samer El-Haj-Mahmoud <el...@hpe.com> > >-----Original Message----- >From: Palmer, Thomas >Sent: Tuesday, March 29, 2016 5:08 PM >To: edk2-devel@lists.01.org >Cc: El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com>; >feng.t...@intel.com; star.z...@intel.com; Palmer, Thomas ><thomas.pal...@hpe.com> >Subject: [PATCH] MdeModulePkg/UefiBootManagerLib: Expose BmLoadOption >function > >Redfine the BmIsValidLoadOptionVariableName function to allow public >use. Change name to EfiBootManagerIsValidLoadOptionVariableName to match >naming scheme. > >Contributed-under: TianoCore Contribution Agreement 1.0 >Signed-off-by: Thomas Palmer <thomas.pal...@hpe.com> >--- > MdeModulePkg/Include/Library/UefiBootManagerLib.h | 23 +++++++++++++++++++++- > .../Library/UefiBootManagerLib/BmLoadOption.c | 9 +++++---- > 2 files changed, 27 insertions(+), 5 deletions(-) > >diff --git a/MdeModulePkg/Include/Library/UefiBootManagerLib.h >b/MdeModulePkg/Include/Library/UefiBootManagerLib.h >index afb4271..e761ef2 100644 >--- a/MdeModulePkg/Include/Library/UefiBootManagerLib.h >+++ b/MdeModulePkg/Include/Library/UefiBootManagerLib.h >@@ -2,7 +2,7 @@ > Provide Boot Manager related library APIs. > > Copyright (c) 2011 - 2015, Intel Corporation. All rights reserved.<BR> >-(C) Copyright 2015 Hewlett Packard Enterprise Development LP<BR> >+(C) Copyright 2015-2016 Hewlett Packard Enterprise Development LP<BR> > This program and the accompanying materials are licensed and made >available under the terms and conditions of the BSD License which >accompanies this distribution. The full text of the license may be found at >@@ -731,4 +731,25 @@ EFIAPI EfiBootManagerProcessLoadOption ( > EFI_BOOT_MANAGER_LOAD_OPTION *LoadOption > ); >+ >+/** >+ Check whether the VariableName is a valid load option variable name >+ and return the load option type and option number. >+ >+ @param VariableName The name of the load option variable. >+ @param OptionType Return the load option type. >+ @param OptionNumber Return the load option number. >+ >+ @retval TRUE The variable name is valid; The load option type and >+ load option number is returned. >+ @retval FALSE The variable name is NOT valid. >+**/ >+BOOLEAN >+EFIAPI >+EfiBootManagerIsValidLoadOptionVariableName ( >+ IN CHAR16 *VariableName, >+ OUT EFI_BOOT_MANAGER_LOAD_OPTION_TYPE *OptionType, >+ OUT UINT16 *OptionNumber >+ ); >+ > #endif >diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmLoadOption.c >b/MdeModulePkg/Library/UefiBootManagerLib/BmLoadOption.c >index 696e995..20fe6af 100644 >--- a/MdeModulePkg/Library/UefiBootManagerLib/BmLoadOption.c >+++ b/MdeModulePkg/Library/UefiBootManagerLib/BmLoadOption.c >@@ -2,7 +2,7 @@ > Load option library functions which relate with creating and processing > load options. > > Copyright (c) 2011 - 2016, Intel Corporation. All rights reserved.<BR> >-(C) Copyright 2015 Hewlett Packard Enterprise Development LP<BR> >+(C) Copyright 2015-2016 Hewlett Packard Enterprise Development LP<BR> > This program and the accompanying materials are licensed and made >available under the terms and conditions of the BSD License which >accompanies this distribution. The full text of the license may be found at >@@ -775,7 +775,8 @@ BmValidateOption ( > @retval FALSE The variable name is NOT valid. > **/ > BOOLEAN >-BmIsValidLoadOptionVariableName ( >+EFIAPI >+EfiBootManagerIsValidLoadOptionVariableName ( > IN CHAR16 *VariableName, > OUT EFI_BOOT_MANAGER_LOAD_OPTION_TYPE *OptionType, > OUT UINT16 *OptionNumber >@@ -853,7 +854,7 @@ EfiBootManagerVariableToLoadOptionEx ( > return EFI_INVALID_PARAMETER; > } > >- if (!BmIsValidLoadOptionVariableName (VariableName, &OptionType, >&OptionNumber)) { >+ if (!EfiBootManagerIsValidLoadOptionVariableName (VariableName, >+ &OptionType, &OptionNumber)) { > return EFI_INVALID_PARAMETER; > } > >@@ -979,7 +980,7 @@ BmCollectLoadOptions ( > > if (CompareGuid (Guid, Param->Guid) && ( > Param->OptionType == LoadOptionTypePlatformRecovery && >- BmIsValidLoadOptionVariableName (Name, &OptionType, &OptionNumber) && >+ EfiBootManagerIsValidLoadOptionVariableName (Name, &OptionType, >+ &OptionNumber) && > OptionType == LoadOptionTypePlatformRecovery > )) { > Status = EfiBootManagerVariableToLoadOptionEx (Name, Guid, >&Option); >-- >1.9.1 > >_______________________________________________ >edk2-devel mailing list >edk2-devel@lists.01.org >https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
