@Liming, Michael: do you have any objections to this patch?

Thanks,
Ard.


On 5 March 2016 at 00:45, Yao, Jiewen <jiewen....@intel.com> wrote:
> Reviewed by: jiewen....@intel.com
>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of 
> evan.ll...@arm.com
> Sent: Saturday, March 05, 2016 1:25 AM
> To: edk2-de...@ml01.01.org; Kinney, Michael D; Gao, Liming
> Cc: leif.lindh...@linaro.org
> Subject: [edk2] [PATCH 1/2] MdePkg: Add ARM Serial Port Subtype definitions
>
> From: Sami Mujawar <sami.muja...@arm.com>
>
> The Serial Port Console Redirection Table specification Version 1.03 - August 
> 10, 2015 adds support for Serial Port Subtypes for ARM. These Subtypes are 
> described in the Table 3 of the Microsoft Debug Port Table
> 2 (DBG2) Specification - December 10, 2015.
>
> This patch adds macro definitions for these.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Alexei Fedorov <alexei.fedo...@arm.com>
> Signed-off-by: Girish Pathak <girish.pat...@arm.com>
> Signed-off-by: Sami Mujawar <sami.muja...@arm.com>
> Signed-off-by: Evan Lloyd <evan.ll...@arm.com>
> ---
>  MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h | 36 
> ++++++++++++++++++--
>  1 file changed, 34 insertions(+), 2 deletions(-)
>
> diff --git 
> a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h 
> b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> index d57518d..dbb5bd9 100644
> --- a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> +++ b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.
> +++ h
> @@ -4,6 +4,7 @@
>
>    Copyright (c) 2007 - 2015, Intel Corporation. All rights reserved.<BR>
>    (C) Copyright 2015 Hewlett Packard Enterprise Development LP<BR>
> +  Copyright (c) 2014 - 2016, ARM Limited. All rights reserved.<BR>
>    This program and the accompanying materials
>    are licensed and made available under the terms and conditions of the BSD 
> License
>    which accompanies this distribution.  The full text of the license may be 
> found at
> @@ -69,11 +70,42 @@ typedef struct {
>  ///
>  /// Full 16550 interface
>  ///
> -#define EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_16550  
>  0
> +#define EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_16550  
>                    0
>  ///
>  /// Full 16450 interface
>  ///
> -#define EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_16450  
>  1
> +#define EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_16450  
>                    1
> +
> +
> +//
> +// The Serial Port Subtypes for ARM are documented in Table 3 of the
> +DBG2 // Specification //
> +
> +///
> +/// ARM PL011 UART
> +///
> +#define 
> EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_ARM_PL011_UART  
>           0x03
> +
> +///
> +/// ARM SBSA Generic UART (2.x) supporting 32-bit only accesses
> +[deprecated] /// #define
> +EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_ARM_SBSA_
> +GENERIC_UART_2X  0x0d
> +
> +///
> +/// ARM SBSA Generic UART
> +///
> +#define 
> EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_ARM_SBSA_GENERIC_UART
>      0x0e
> +
> +///
> +/// ARM DCC
> +///
> +#define 
> EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_ARM_DCC         
>           0x0f
> +
> +///
> +/// BCM2835
> +///
> +#define 
> EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_BCM2835_UART    
>           0x10
>
>  //
>  // Interrupt Type
> --
> 2.7.0
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to