MdeModelPkg/IntelFrameworkModulePkg reviewed by: jiewen....@intel.com > -----Original Message----- > From: Zeng, Star > Sent: Wednesday, April 6, 2016 8:40 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen <jiewen....@intel.com>; Tian, Feng <feng.t...@intel.com>; > Fan, Jeff <jeff....@intel.com>; Laszlo Ersek <ler...@redhat.com>; Justen, > Jordan L <jordan.l.jus...@intel.com> > Subject: [PATCH V2 0/8] Move S3Ready() functional code from > AcpiS3SaveDxe to S3SaveStateDxe > > The S3Ready() functional code in AcpiS3SaveDxe of > IntelFrameworkModulePkg > is to do ACPI S3 Context save. In fact, that is not really related to > Intel framework ACPI S3 protocol. > > IntelFrameworkModulePkg will be deprecated step by step, so move the > functional code to MdeModulePkg and S3SaveStateDxe is a good place. > The ACPI global variable related code is leaved as is in > IntelFrameworkModulePkg > AcpiS3SaveDxe for compatibility. > PcdS3BootScriptStackSize is also moved from IntelFrameworkModulePkg. > > The functional code need to get ACPI FACS table and consume LockBoxLib, > so need to be before DxeSmmReadyToLock that will shut down SMM lock > box > interface, EndOfDxe is a good time point (OVMF AcpiS3SaveDxe has the > reference implementation). > > After the movement, AcpiS3SaveDxe in OvmfPkg could be retired. > With this patch series, I did S3 test on real platform and normal boot for > OVMF. > > Laszlo & Jordan, could you help confirm the S3 functionality for OVMF? > > V2: > Major change to V1 is to introduce a new PCD PcdAcpiS3Enable. > It is for the concern to V1, detailed discussion about V1 is at > http://article.gmane.org/gmane.comp.bios.edk2.devel/10261 > > Cc: Jiewen Yao <jiewen....@intel.com> > Cc: Feng Tian <feng.t...@intel.com> > Cc: Jeff Fan <jeff....@intel.com> > Cc: Laszlo Ersek <ler...@redhat.com> > Cc: Jordan Justen <jordan.l.jus...@intel.com> > Star Zeng (8): > MdeModulePkg: Introduce new PCD PcdAcpiS3Enable > OvmfPkg: Set PcdAcpiS3Enable according to QemuFwCfgS3Enabled() > OvmfPkg: Install LockBox protocol in constructor of LockBoxDxeLib > MdeModulePkg S3SaveStateDxe: Consume PcdAcpiS3Enable to control > the > code > MdeModulePkg S3SaveStateDxe: Move S3Ready() functional code from > AcpiS3SaveDxe > OvmfPkg: Retire AcpiS3SaveDxe > IntelFrameworkModulePkg AcpiS3SaveDxe: Consume PcdAcpiS3Enable to > control the code > IntelFrameworkModulePkg AcpiS3SaveDxe: Remove S3Ready() functional > code > > .../IntelFrameworkModulePkg.dec | 8 +- > .../IntelFrameworkModulePkg.uni | 6 +- > .../Universal/Acpi/AcpiS3SaveDxe/AcpiS3Save.c | 455 > +-------------------- > .../Universal/Acpi/AcpiS3SaveDxe/AcpiS3SaveDxe.inf | 12 +- > .../Acpi/AcpiS3SaveDxe/AcpiVariableThunkPlatform.c | 6 +- > MdeModulePkg/MdeModulePkg.dec | 12 + > MdeModulePkg/MdeModulePkg.uni | 10 + > .../Acpi/S3SaveStateDxe/AcpiS3ContextSave.c | 212 +++++----- > .../Acpi/S3SaveStateDxe/InternalS3SaveState.h | 18 +- > .../Universal/Acpi/S3SaveStateDxe/S3SaveState.c | 17 +- > .../Acpi/S3SaveStateDxe/S3SaveStateDxe.inf | 22 +- > OvmfPkg/AcpiS3SaveDxe/AcpiS3SaveDxe.inf | 77 ---- > OvmfPkg/Library/LockBoxLib/LockBoxDxe.c | 31 +- > OvmfPkg/Library/LockBoxLib/LockBoxDxeLib.inf | 6 +- > OvmfPkg/OvmfPkgIa32.dsc | 2 +- > OvmfPkg/OvmfPkgIa32.fdf | 3 +- > OvmfPkg/OvmfPkgIa32X64.dsc | 2 +- > OvmfPkg/OvmfPkgIa32X64.fdf | 3 +- > OvmfPkg/OvmfPkgX64.dsc | 2 +- > OvmfPkg/OvmfPkgX64.fdf | 3 +- > OvmfPkg/PlatformPei/Platform.c | 4 +- > OvmfPkg/PlatformPei/PlatformPei.inf | 3 +- > 22 files changed, 226 insertions(+), 688 deletions(-) > rename OvmfPkg/AcpiS3SaveDxe/AcpiS3Save.c => > MdeModulePkg/Universal/Acpi/S3SaveStateDxe/AcpiS3ContextSave.c (74%) > delete mode 100644 OvmfPkg/AcpiS3SaveDxe/AcpiS3SaveDxe.inf > > -- > 2.7.0.windows.1
_______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
