On 04/07/16 13:18, Laszlo Ersek wrote:
> On 04/06/16 18:15, Ard Biesheuvel wrote:
>> +
>> + GicRevision = 2;
>> + Status = FdtClient->FindCompatibleNodeReg (FdtClient,
>> + "arm,cortex-a15-gic",
>> + &Reg,
>> + &RegElemSize,
>> + &RegSize);
>
> (26) The indentation of the arguments is not correct; they should be
> aligned with "FindCompatibleNodeReg", plus one or two spaces.
>
> Can you re-check the series for such indentation problems?
FWIW, I personally subscribe to two indentation styles in edk2: the
official one, and my own "compressed" variant of it. They are:
Status = FdtClient->FindCompatibleNodeReg (
FdtClient,
"arm,cortex-a15-gic",
&Reg,
&RegElemSize,
&RegSize
);
That is, no argument on the first line, indentation as described above,
closing paren on separate line. Or (mine):
Status = FdtClient->FindCompatibleNodeReg (FdtClient,
"arm,cortex-a15-gic", &Reg, &RegElemSize,
&RegSize);
Which is same as yours, except the arguments are not aligned with the
first argument, but two columns to the right of the member function's name.
Thanks!
Laszlo
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel
