On 2016/4/8 14:55, Yao, Jiewen wrote:
Thanks.
1/3 - I think this is valuable to save SMRAM size. Reviewed-by:
[email protected]
2/3 - I think this is valuable to save Reserved memory size. Reviewed-by:
[email protected]
3/3 - I have concern on this one, because MasterBootMode cannot be used as
indicator for S3 mode or not. It cannot be used as indicator if this PCD is
ready or not. Also, I do not see big benefit on just saving one PPI data
structure. It has no impact to OS. I suggest we drop it.
If the PcdAcpiS3Enable is declared as FixedAtBuild, platform can switch
out the S3Resume2Pei in *.dsc and *.fdf, then the check has no benefit.
If the PcdAcpiS3Enable is declared as Dynamic, we can save only one PPI
at most as PEI phase has no unload.
Ok, I admit its benefit is small. I will drop this [3/3] patch.
Thanks,
Star
Thank you
Yao Jiewen
-----Original Message-----
From: Zeng, Star
Sent: Friday, April 8, 2016 2:28 PM
To: [email protected]
Cc: Tian, Feng <[email protected]>; Yao, Jiewen <[email protected]>;
Fan, Jeff <[email protected]>; Laszlo Ersek <[email protected]>
Subject: [PATCH 0/3] Update some S3 related modules to consume
PcdAcpiS3Enable to control the code
Cc: Feng Tian <[email protected]>
Cc: Jiewen Yao <[email protected]>
Cc: Jeff Fan <[email protected]>
Cc: Laszlo Ersek <[email protected]>
Laszlo, I guess you have interest.
Star Zeng (3):
MdeModulePkg SmmS3SaveStateDxe: Consume PcdAcpiS3Enable to
control the
code
MdeModulePkg BootScriptExecutorDxe: Consume PcdAcpiS3Enable to
control
the code
UefiCpuPkg S3Resume2Pei: Consume PcdAcpiS3Enable to control the
code
.../Universal/Acpi/BootScriptExecutorDxe/BootScriptExecutorDxe.inf | 3
++-
MdeModulePkg/Universal/Acpi/BootScriptExecutorDxe/ScriptExecute.c |
6 +++++-
MdeModulePkg/Universal/Acpi/SmmS3SaveState/SmmS3SaveState.c
| 7 +++++--
MdeModulePkg/Universal/Acpi/SmmS3SaveState/SmmS3SaveState.inf
| 6 +++++-
UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c
| 6 +++++-
UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume2Pei.inf
| 5 +++--
6 files changed, 25 insertions(+), 8 deletions(-)
--
2.7.0.windows.1
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel
