On 04/08/16 20:36, Mark wrote: > I cloned your github but couldn't find the appropriate branch to build. > > [m@ornage edk2]$ git status > On branch remove_old_pci_host > Your branch is up-to-date with 'origin/remove_old_pci_host'. > nothing to commit, working directory clean > > If that is the one, I built it successfully but did not solve the > performance issue. > > Should I be in another branch?
Please see the cover letter of the v2 series that I CC'd you on (although I forgot to mark the subject as v2): http://thread.gmane.org/gmane.comp.bios.edk2.devel/10511 It states that the branch name is "ide_perf_fix_v2". Thanks Laszlo > > On Fri, Apr 8, 2016 at 2:08 AM, Laszlo Ersek <ler...@redhat.com > <mailto:ler...@redhat.com>> wrote: > > On 04/08/16 05:09, Mark wrote: > > Yes I'm the same person. :) > > > > Currently I am using /usr/share/ovmf/x64/ovmf_code_x64.bin built from > > arch user repo package ovmf-git on 5 Apr 2016. When I was > reporting the > > issues, I was using > > edk2.git-ovmf-x64-0-20160324.b1635.gf0bbcdf.noarch.rpm from the > Gerd repo. > > > > CPU on the host had a single core pegged during the poor performance. > > > > Multiple distros was referring to the host, sorry for the > ambiguity. I > > also tried arch linux on a guest just to see if it was a win7 iso > issue, > > the xml dump was dumped at a moment I had that arch ISO loaded. > > > > I just rebuilt ovmf-git 18308.8207d79-1 (Thu Apr 7 20:04:21 PDT 2016) > > and the issue still exists, I see that it is being addressed. > > > > Thanks to everyone who contributes to this project, I enjoy the > product > > very much. If there is any more info I can provide, please ask. > > Can you perhaps confirm the fix works? I'll soon send a v2, and push it > to my personal github repo as well. If you could fetch it, build it, and > test it, that would be great. > > Thanks! > Laszlo > > > On Thu, Apr 7, 2016 at 12:36 PM, Laszlo Ersek <ler...@redhat.com > <mailto:ler...@redhat.com> > > <mailto:ler...@redhat.com <mailto:ler...@redhat.com>>> wrote: > > > > On 04/07/16 20:24, Jordan Justen wrote: > > > On 2016-04-07 08:07:35, Laszlo Ersek wrote: > > >> I like the diffstat on this one. > > >> > > > > > > :) > > > > > > Series Reviewed-by: Jordan Justen <jordan.l.jus...@intel.com > <mailto:jordan.l.jus...@intel.com> > > <mailto:jordan.l.jus...@intel.com > <mailto:jordan.l.jus...@intel.com>>> > > > > Thanks. Committed as aa47e5297851..4a392a451d4d. > > > > > Ray, > > > > > > I noticed one possible issue. With the new driver, did we > lose this > > > commit? > > > > > > commit 1fd376d979221e9765dbec215916f5a6ab92879f > > > > > > PcAtChipsetPkg/PciHostBridgeDxe: Improve KVM FIFO I/O > > read/write performance > > > > I think so. Apologies for not noticing it. :( > > > > I hope that Ray can resurrect / reapply the C code directly > from the > > commit you reference above, and the assembly (in NASM syntax) from > > 6026bf460037 and ace1d0517b65. > > > > > Laszlo, > > > > > > Someone was reporting slowness with the Windows 7 ISO on irc > a few > > > days back. Maybe this is the cause? > > > > > > I don't think this would impact virtio performance. > > > > I think you are referring to the following discussion on April > 4th: > > > > > <Naruni> hello, im having performance issues when using ovmf > > > (OVMF_CODE-pure-efi.fd from gerd hoffman repo) in QEMU > > > emulator version 2.3.0 (Debian 1:2.3+dfsg-5ubuntu9.2) > > > > > > <Naruni> the specific issue im having is slow performance > while trying > > > to install win7, the initial screen 'loading > windows files' > > > is very slow and im only getting about 1 MB/sec disk IO > > > according to iotop > > > > > > <Naruni> if i use a VM in bios mode it operates at full > performance > > > > > > <Naruni> this behavior is the same across multiple distros > (ubuntu, > > > debian, arch, and gentoo) > > > > > > <Naruni> kvm is enabled and working according to qemu monitor > > > > > > <lersek> Naruni, what kind of virtual disk are you using? > Are you > > > using virtio-blk or virtio-scsi with OVMF as well? > > > > > > <lersek> Naruni, also, I guess the best "advice" I can give > at the > > > moment is: "just use the most recent upstream QEMU > release". > > > > Unfortunately, "Naruni" didn't respond (I'll admit that I > noticed his > > question only 90 minutes later or so). > > > > However, I am now putting this together with an email, on the > vfio-users > > list (also April 4th): > > > > > https://www.redhat.com/archives/vfio-users/2016-April/msg00029.html > > > > The description is practically identical, so I'm thinking the > same user > > reported it. I'm adding the email address from the latter > message to the > > Cc list now. Mark, are you Naruni? :) > > > > Unfortunately, the report doesn't name the version of Gerd's > OVMF RPM in > > use. It also doesn't say whether the CPU was pegged while > experiencing > > the slow performance. > > > > The "multiple distros" comment in the IRC report is not clear > -- does > > that mean multiple distros as guests, or hosts? I guess it's > the former; > > first, the host is reported as "QEMU emulator version 2.3.0 > (Debian > > 1:2.3+dfsg-5ubuntu9.2)", while the domain XML pasted into > Mark's email > > lists an ArchLinux installer ISO (i.e., guest). > > > > The domain XML clarifies another thing: the CD-ROM is IDE, not > > virtio-scsi. Also, there is no other disk drive (of any kind). > > > > Let me see if I can reproduce this, and perhaps bisect it. > > > > Mark, if you want to follow up on this list (= edk2-devel), > please note > > that first you will have to subscribe to the list (and await the > > confirmation), at > <https://lists.01.org/mailman/listinfo/edk2-devel>. > > > > Thanks > > Laszlo > > > > > > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
